Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated Terminal is slow when wrapping very long line #102705

Closed
crystalin opened this issue Jul 16, 2020 · 8 comments
Closed

Integrated Terminal is slow when wrapping very long line #102705

crystalin opened this issue Jul 16, 2020 · 8 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@crystalin
Copy link

crystalin commented Jul 16, 2020

  • VSCode Version: 1.47.1 & 1.48.0-insider
  • OS Version: Windows NT x64 10.0.19042

Steps to Reproduce:

  1. generate a long line in terminal, exemple (javascript):
let data = [];
for (let i = 0; i<20000; i++) {
    data.push(Math.floor(Math.random() * 16).toString(16));
}
console.log(data.join(''));
  1. observe how slow it is (scrolling up into the middle of the text makes it even worse)

This issue appears with --disable-extensions also with --disable-gpu or with any choice of terminal.integrated.rendererType.
This issue is independent of the shell (powershell, cmd, wsl.... all have the issue)
VsCode also freezes when the terminal freezes (If the line is very long, it might trigger notification to "kill or wait vscode")

During the freeze, CPU is at around 10% (high considering there are 8/16 cores), GPU at 0%

Keeping the terminal visible (without any changes in its content) makes VSCode slow. The more of the lines is displayed, but also the longer the text is (outside of the visible area), the slower it gets.

Hiding the terminal by switching to another one restore the UI responsiveness to the normal.

I suspect this is related to the computation of the line wrap.

@Noh3choo
Copy link

Noh3choo commented Jul 17, 2020

+1 same exact issue here, any very long line printed to the integrated terminal sends 1 thread to 100% and locks up the entire IDE if any attempt to scroll back in the terminal pane is made.

I experience this on:

  • Ubuntu 20.04 LTS
  • VSCode 1.47.1

@Tyriar
Copy link
Member

Tyriar commented Aug 3, 2020

/duplicate #74620

@Tyriar Tyriar closed this as completed Aug 3, 2020
@Tyriar
Copy link
Member

Tyriar commented Aug 3, 2020

@Noh3choo you might be using the dom renderer, try this setting "terminal.integrated.rendererType": "experimentalWebgl"

@crystalin
Copy link
Author

@Tyriar, it is still failing with "terminal.integrated.rendererType": "experimentalWebgl"

@Tyriar
Copy link
Member

Tyriar commented Aug 4, 2020

@crystalin your issue is likely the Windows-specific #74620

@Noh3choo
Copy link

Noh3choo commented Aug 4, 2020

@crystalin your issue is likely the Windows-specific #74620

I don’t think it is, this is a recent regression and not a duplicate.

I am not using the DOM renderer and setting experimentalWebgl has not affect on the bug.

@Tyriar
Copy link
Member

Tyriar commented Aug 4, 2020

@Noh3choo on Linux if you have problems scrolling, it's renderer related. You can try launching with --disable-gpu, changing the renderer or updating your gpu drivers. Your issue is different to @crystalin's.

@Noh3choo
Copy link

Noh3choo commented Aug 4, 2020

Thanks Tyriar,

I have tried all of your suggestions and none change the behavior.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

4 participants
@crystalin @Tyriar @Noh3choo and others