Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New windows inherit/merge environment from existing windows #107998

Closed
AngryCochinoPup opened this issue Oct 2, 2020 · 5 comments
Closed

New windows inherit/merge environment from existing windows #107998

AngryCochinoPup opened this issue Oct 2, 2020 · 5 comments
Assignees
@bpasero
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-cli VS Code Command line issues
Milestone
November 2020

Comments

@AngryCochinoPup
Copy link

Issue Type: Bug

  1. Open two tabs in a terminal emulator
  2. In tab 1: export TEST_VAR=1
  3. In tab 2: export TEST_VAR=2
  4. In tab 1: code --new-window .
  5. In tab 2: code --new-window .
  6. In Code window 2 terminal: echo $TEST_VAR
    TEST_VAR has the value 1, not 2. This is wrong.
    Using --sync off helps some, as tab 2 will get its own value for TEST_VAR, but it will still inherit any values in tab 1's environment that are not overwritten.
    This is a disaster for my workflow, as I have different tabs with different environments set up to work on different programs.
    Please tell me there is a way to turn this off completely.

VS Code version: Code 1.49.2 (e5e9e69, 2020-09-24T16:26:09.944Z)
OS version: Linux x64 3.10.0-1062.4.1.el7.x86_64
@meganrogge meganrogge added the bug Issue identified by VS Code Team member as probable bug label Nov 4, 2020
@meganrogge meganrogge added this to the Backlog milestone Nov 4, 2020
@Tyriar
Copy link
Member

Tyriar commented Nov 4, 2020

/duplicate #15452

@Tyriar Tyriar closed this as completed Nov 4, 2020
@Tyriar Tyriar removed the bug Issue identified by VS Code Team member as probable bug label Nov 4, 2020
@bpasero bpasero assigned bpasero and unassigned Tyriar Nov 21, 2020
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-cli VS Code Command line issues and removed *duplicate Issue identified as a duplicate of another issue(s) labels Nov 21, 2020
@bpasero bpasero modified the milestones: Backlog, November 2020 Nov 21, 2020
@bpasero
Copy link
Member

bpasero commented Nov 21, 2020

Fixed as outlined in #108804 (comment) for November.

@bpasero bpasero added the author-verification-requested Issues potentially verifiable by issue author label Nov 23, 2020
@github-actions
Copy link

Unable to locate closing commit in issue timeline. You can manually reference a commit by commenting \closedWith someCommitSha.

@github-actions github-actions bot removed the author-verification-requested Issues potentially verifiable by issue author label Nov 23, 2020
@bpasero
Copy link
Member

bpasero commented Nov 23, 2020

\closedWith 6f3fcd2

@bpasero bpasero added the author-verification-requested Issues potentially verifiable by issue author label Nov 23, 2020
@github-actions
Copy link

This bug has been fixed in to the latest release of VS Code Insiders!

@AngryCochinoPup, you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text /verified to let us know. If not, please ensure you're on version 6026ab5 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@lszomoru lszomoru added the verified Verification succeeded label Dec 7, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded workbench-cli VS Code Command line issues
Projects
None yet
Milestone
November 2020
Development

No branches or pull requests
6 participants
@bpasero @Tyriar @lszomoru @meganrogge @AngryCochinoPup and others