Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disposing activeTerminal causes te renderer to freeze #115927

Closed
connor4312 opened this issue Feb 5, 2021 · 5 comments
Closed

Disposing activeTerminal causes te renderer to freeze #115927

connor4312 opened this issue Feb 5, 2021 · 5 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues terminal General terminal issues that don't fall under another label

Comments

@connor4312
Copy link
Member

  1. In an extension, have
import * as vscode from 'vscode';

export function activate(context: vscode.ExtensionContext) {
	const disposable = vscode.commands.registerCommand('extension.helloWorld', () => {
		vscode.window.activeTerminal?.dispose();
	});

	context.subscriptions.push(disposable);
}
  1. Open the terminal
  2. Type in text (this is required, uninteracted terminals don't trigger this)
  3. Run the command
  4. After several seconds, the window will freeze
@connor4312 connor4312 added freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues terminal General terminal issues that don't fall under another label labels Feb 5, 2021
@Tyriar
Copy link
Member

Tyriar commented Feb 5, 2021

/duplicate #76548

@Tyriar Tyriar closed this as completed Feb 5, 2021
@connor4312
Copy link
Member Author

connor4312 commented Feb 5, 2021

Oh yea, I didn't check but this happens when closing any terminal, manually too... pretty sure this is new to recent builds (or OS update), this would otherwise make the integrated terminal pretty risky to use for me (having to kill all vscode windows if I accidentally close a terminal)

@Tyriar
Copy link
Member

Tyriar commented Feb 5, 2021

It could have been an OS update, it also seems to repro at different rates for different people, I guess depending on hardware specs and usage habits.

@connor4312
Copy link
Member Author

Sounds good. I will rebuild my PC in a week or two in order to attempt a workaround.

(Just waiting on the 3080 to ship 🙂 )

@Tyriar
Copy link
Member

Tyriar commented Feb 5, 2021

Jealous 🙄

@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues terminal General terminal issues that don't fall under another label
Projects
None yet
Development

No branches or pull requests

3 participants
@Tyriar @connor4312 and others