You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I feel the editorOpenWith.ts thing needs to go away and move to respective services. It seems wrong to me that you pass in an editor group to operate on instead of having this exposed from the IEditorGroupService. Here is my thinking:
add a new method to IEditorGroup (e.g. openEditorWith)
clients will use IEditorGroupService.getGroup().openEditorWith(...)
I feel the
editorOpenWith.ts
thing needs to go away and move to respective services. It seems wrong to me that you pass in an editor group to operate on instead of having this exposed from theIEditorGroupService
. Here is my thinking:IEditorGroup
(e.g.openEditorWith
)IEditorGroupService.getGroup().openEditorWith(...)
As for the remaining pieces of
editorOpenWith.ts
we can simply move them intosrc/vs/workbench/common/editor.ts
at the end into a new folded region.The text was updated successfully, but these errors were encountered: