Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting started - primary walkthrough not opening #119620

Closed
lszomoru opened this issue Mar 23, 2021 · 5 comments
Closed

Getting started - primary walkthrough not opening #119620

lszomoru opened this issue Mar 23, 2021 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug getting-started insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@lszomoru
Copy link
Member

lszomoru commented Mar 23, 2021

Testing #119543

  • Start VS Code and have "Getting Started" editor opened
  • Set "workbench.welcomePage.experimental.extensionContributions": "open"
  • Have another file opened (ex: settings.json) which is the focused tab.
  • Install the md-to-html extension.

Expected: Primary walkthrough should open. (this works as expected is the "Getting Started" editor is not opened)
Actual: Item is added under the "Getting Started" section but walkthrough is not opening.

@JacksonKearl
Copy link
Contributor

Verify: "workbench.welcomePage.experimental.extensionContributions" is now boolean, the only (exposed) behaviour is when installing an extensions with a "primary": true, walkthrough:

  • If there are any getting started pages which are not opened to any walkthrough (the index page), make one of them visible, and set it to show the newly added walkthrough
  • Otherwise, open a new getting started page to this walkthrough

The main thing is that there should be a getting started page active, showing the walkthrough, and that no getting started page which had been showing a different walkthrough should be overwritten (though it may become hidden).

@JacksonKearl JacksonKearl added feature-request Request for new features or functionality bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels May 10, 2021
@andreamah
Copy link
Contributor

andreamah commented Jun 4, 2021

For verification purposes, is "workbench.welcomePage.experimental.extensionContributions" now the workbench.welcomePage.experimental.startEntryContributions boolean? If so, everything looks good!

@JacksonKearl
Copy link
Contributor

Yep, thanks!

@andreamah andreamah added the verified Verification succeeded label Jun 4, 2021
@MrSkittles1
Copy link

How do I get to that page to check that the workbench is true?

@JacksonKearl
Copy link
Contributor

@MrSkittles1 I do not understand the question. You can open the page under question with Help: Getting Started in Stable or Help: Welcome in Insiders

@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug getting-started insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants
@Tyriar @lszomoru @JacksonKearl @andreamah @MrSkittles1 and others