Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension is in odd disabled / enabled state when trying to enable an extension on a VS Code version that does not support it #144444

Closed
IanMatthewHuff opened this issue Mar 4, 2022 · 2 comments · Fixed by #146500
Assignees
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan ux User experience issues
Milestone

Comments

@IanMatthewHuff
Copy link
Member

Does this issue occur when all extensions are disabled?: No

  • VS Code Version: 1.66-insiders
  • OS Version: macOS monterey

This is a bit tricky as I'm not sure how to re-engineer this situation for the repro. But the repro is as follows.

  1. VS Code Insiders 1.65
  2. Install the .NET Interactive extension (version 310011 targets 1.65-insiders)
  3. Disable the extension
  4. VS Code Insiders updated to 1.66
  5. Attempt to enable the .NET Interactive extension (note at this point there is no version that targets 1.66-insiders on the market)
  6. Extension is now in a state where it cannot be enabled or disabled and I don't see an indication that the reason it's disabled is the engine version mismatch

image

image

@sandy081
Copy link
Member

sandy081 commented Mar 7, 2022

It seems the enabled extension is not compatible with the current VSCode engine and hence it is not loaded. Enablement actions are disabled because none of these actions are useful in this context. I think it would be useful to inform user that this extension cannot be enabled/disabled because it is not compatible.

@sandy081 sandy081 added extensions Issues concerning extensions ux User experience issues labels Mar 7, 2022
@sandy081 sandy081 added this to the Backlog milestone Mar 7, 2022
@sandy081 sandy081 modified the milestones: Backlog, April 2022 Apr 1, 2022
@sandy081 sandy081 added the feature-request Request for new features or functionality label Apr 1, 2022
@sandy081
Copy link
Member

sandy081 commented Apr 1, 2022

After further investigation, the root cause of this issue is that Extension UI and Extension Host (Runtime Extensions) are not in sync. UI expects that this extension is enabled and supposed to be running and Extension Host is correctly not running this extension because of engine compatibility. There are more such scenarios where these two components do not agree with each other.

From Day 1, these components are not aligned and each scan extensions in its own way. I am planning to align these by unifying extension scanning. This will make UI in sync with Runtime.

CC @alexdima

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan ux User experience issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@IanMatthewHuff @sandy081 and others