Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal scroll bar annotations #144595

Closed
Tyriar opened this issue Mar 7, 2022 · 2 comments
Closed

Terminal scroll bar annotations #144595

Tyriar opened this issue Mar 7, 2022 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality on-testplan terminal-shell-integration Shell integration infrastructure, command decorations, etc. upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 7, 2022

We want to add monaco-style annotations to the terminal, some example uses:

Unknowns:

  • It seems like this would cause an awfully noisy scroll bar if many small commands are run
@Tyriar Tyriar added feature-request Request for new features or functionality terminal-shell-integration Shell integration infrastructure, command decorations, etc. labels Mar 7, 2022
@Tyriar Tyriar added this to the March 2022 milestone Mar 7, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Mar 7, 2022

Upstream issue: xtermjs/xterm.js#3632

@Tyriar Tyriar added upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream labels Mar 7, 2022
@Tyriar Tyriar removed their assignment Mar 8, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Mar 17, 2022

Think we can call this done now

@Tyriar Tyriar closed this as completed Mar 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-testplan terminal-shell-integration Shell integration infrastructure, command decorations, etc. upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Development

No branches or pull requests

2 participants