Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[folding] organize imports on save expands minimized imports #156675

Closed
emiomacollins opened this issue Jul 29, 2022 · 1 comment · Fixed by #226479
Closed

[folding] organize imports on save expands minimized imports #156675

emiomacollins opened this issue Jul 29, 2022 · 1 comment · Fixed by #226479
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-folding Editor code folding issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@emiomacollins
Copy link

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.69.2
  • OS Version: windows

Steps to Reproduce:

  1. add this to settings.json
    "editor.codeActionsOnSave": {
    "source.organizeImports": true
    },
  2. minimize your imports
  3. save
  4. imports get expanded automatically

it's a bit annoying to manually minimize imports every time I save. and I also like having my imports get organized on save, it helps remove unused imports.

@mjbvz mjbvz assigned aeschli and unassigned mjbvz Aug 1, 2022
@mjbvz
Copy link
Collaborator

mjbvz commented Aug 1, 2022

Also partially caused by microsoft/TypeScript#39823 but that's only for cases where the imports are already sorted

@aeschli aeschli changed the title organize imports on save expands minimized imports [dolcing] organize imports on save expands minimized imports Aug 24, 2022
@aeschli aeschli added editor-folding Editor code folding issues bug Issue identified by VS Code Team member as probable bug labels Aug 24, 2022
@aeschli aeschli added this to the August 2022 milestone Aug 24, 2022
@aeschli aeschli changed the title [dolcing] organize imports on save expands minimized imports [folding] organize imports on save expands minimized imports Aug 24, 2022
@aeschli aeschli modified the milestones: August 2022, September 2022 Aug 24, 2022
@aeschli aeschli modified the milestones: September 2022, October 2022 Sep 26, 2022
@rebornix rebornix modified the milestones: October 2022, November 2022 Oct 25, 2022
@aeschli aeschli modified the milestones: November 2022, December 2022 Nov 28, 2022
@aeschli aeschli modified the milestones: January 2023, February 2023 Jan 23, 2023
@aeschli aeschli modified the milestones: February 2023, March 2023 Feb 20, 2023
@aeschli aeschli modified the milestones: March 2023, Backlog Mar 20, 2023
@justschen justschen self-assigned this Aug 5, 2024
@justschen justschen modified the milestones: Backlog, August 2024 Aug 5, 2024
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Aug 24, 2024
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 26, 2024
@mjbvz mjbvz added the verified Verification succeeded label Aug 27, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-folding Editor code folding issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants