Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock icon inconsistency between output and editor groups #162441

Open
bpasero opened this issue Sep 30, 2022 · 2 comments
Open

Lock icon inconsistency between output and editor groups #162441

bpasero opened this issue Sep 30, 2022 · 2 comments
Assignees
Labels
polish Cleanup and polish issue ux User experience issues

Comments

@bpasero
Copy link
Member

bpasero commented Sep 30, 2022

We recently changed the output lock icon to show a lock when the output is not locked (@mjbvz @sandy081). However we have other locations in the UI that use the lock icon, for example when you open a second editor group, you can lock it from the "..." menu:

image

Here the icon indicates the current state, where as in output channel it indicates the state after clicking.

This is a UX inconsistency.

@bpasero bpasero added the ux User experience issues label Sep 30, 2022
@bpasero
Copy link
Member Author

bpasero commented Sep 30, 2022

Somewhat similar we have an icon that shows for pinned editors, where the icon indicates the current state:

image

@gjsjohnmurray
Copy link
Contributor

https://code.visualstudio.com/api/ux-guidelines/editor-actions could usefully say what the convention is, though that page is framed as specific to editor actions. I didn't find one for actions in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
polish Cleanup and polish issue ux User experience issues
Projects
None yet
Development

No branches or pull requests

3 participants