Duplicated Task / Inconsistent Naming / Missing Details

[hediet]

Steps Bug 1:

• clone https://github.com/hediet/vscode-debug-visualizer/
• Run Tasks: Run Task

Actual result:

Expected result:

• npm: dev - extension should not appear twice
• every entry should have details, not just npm: dev - webview

Steps Bug 2:

• Run both of the dev - extension tasks (kill the other before running each)
  • Notice that one of the tasks does not pick up the problemMatcher configured in tasks.json (VS Code shows the loading indicator forever in that case)

Steps Bug 3:

• Use extension API vscode.tasks.fetchTasks to query all tasks
  • Notice that the name of the first duplicate is npm: dev - extension (as configured in tasks.json) and the other is just dev - extension

Probably all bugs have the same source, thus filing just one issue.

[hediet]

If details are shown or not is also not deterministic:

image.png

[meganrogge]

npm: dev - extension should not appear twice

For me, it only appears twice if I have two tasks with that label in the tasks.json, which is not how that repo has things configured by default. That is as designed.

every entry should have details, not just npm: dev - webview

It only shows details for tasks that have the detail property set by design

[meganrogge]

What you have described suggests you have two tasks like the above configured.

[vscodenpa]

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

[hediet]

Let's meet and discuss this, as it consistently reproduces for me.

[vscodenpa]

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

[meganrogge]

It exists here as both a customized task and a contributed one

[meganrogge]

and custom tasks have no details, which is why those were missing

[meganrogge]

That task lives in the .vscode/tasks.json file of the vscode-debug-visualizer workspace

[meganrogge]

I see why you were confused by this @hediet , as the tasks are detected from many places within that particular workspace. Please let me know if you have any other questions

[meganrogge]

Consulted with @alexr00 and in this case, we'd expect those to be merged into one, but the / in the path:"extension/" is what's causing this to happen because it's not equal to the path of the other task. Removing that fixes this

[meganrogge]

[hediet]

is what's causing this to happen because it's not equal to the path of the other task. Removing that fixes this

I'd expect extension/ and extension to behave the same.

Also, I just tested this with 1.40.2, where it works (only a single npm: dev - extension is shown):

Thus it seems this is a regression.

[alexr00]

The trailing slash in extension/ was a bug. This bug was fixed with #146165.

An unfortunate side effect of fixing the trailing slash bug is that now some tasks.json files where the tasks were created during a time where the / bug was occurring will have an extra / in the path of npm script tasks.

An extension provided task, such as an npm type task, is identified by the properties the extension defines for the task type. For npm, this is script and path. When the npm extension provides tasks to VS Code, they are now properly without the trailing /. However, your tasks.json still has the erroneous /. The two tasks now have different IDs and cannot be merged.

[hediet]

Ahh, that makes sense.

[alexr00]

Your task with the trailing slash should still work (mitigating the issue), but we can't really merge them without making core VS Code have specific knowledge of how npm tasks work.