Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SHA checksum verification when downloading Electron, Node and built-in extensions #184885

Closed
3 tasks done
bpasero opened this issue Jun 12, 2023 · 1 comment · Fixed by #185568
Closed
3 tasks done

Add SHA checksum verification when downloading Electron, Node and built-in extensions #184885

bpasero opened this issue Jun 12, 2023 · 1 comment · Fixed by #185568
Assignees
@bpasero @deepak1556
Labels
engineering VS Code - Build / issue tracking / etc. plan-item VS Code - planned item for upcoming
Milestone
June 2023

Comments

@bpasero
Copy link
Member

bpasero commented Jun 12, 2023 •
edited by deepak1556
Loading

Today when running out of sources and/or building, we get some components from online resources such as GitHub or our Marketplace. We should add SHA256 checksum verification to these:
@bpasero bpasero added plan-item VS Code - planned item for upcoming engineering VS Code - Build / issue tracking / etc. labels Jun 12, 2023
@bpasero bpasero added this to the June 2023 milestone Jun 12, 2023
@bpasero
Copy link
Member Author

bpasero commented Jun 12, 2023

Adding the foundation for this for node.js and extensions in #184877

@kieferrm kieferrm mentioned this issue Jun 12, 2023
Closed
74 tasks
@bpasero bpasero mentioned this issue Jun 13, 2023
Merged
@deepak1556 deepak1556 mentioned this issue Jun 19, 2023
Merged
@bpasero bpasero moved this to 🏃 In Progress in VSCode Electron Integration Jul 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@deepak1556 deepak1556

Labels
engineering VS Code - Build / issue tracking / etc. plan-item VS Code - planned item for upcoming
Projects
VSCode Electron Integration
Archived in project
Milestone
June 2023
Development

Successfully merging a pull request may close this issue.

chore: add checksum for electron assets microsoft/vscode
3 participants
@bpasero @deepak1556 @connor4312