Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension API request: vscode.Terminal.onBufferChange #206832

Closed
ArkaneMoose opened this issue Mar 4, 2024 · 1 comment
Closed

Extension API request: vscode.Terminal.onBufferChange #206832

ArkaneMoose opened this issue Mar 4, 2024 · 1 comment
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@ArkaneMoose
Copy link

Hello, I'd like to request a new extension API:

vscode.Terminal.onBufferChange: vscode.Event<'normal' | 'alternate'>

This would expose the existing Xterm.js event Terminal.buffer.onBufferChange: IEvent<IBuffer>.
The event parameter 'normal' | 'alternate' would come from the type property of the IBuffer passed to the Xterm.js event callback.

I'd like to use such an API to implement a small extension that maximizes the VS Code integrated terminal when it switches to the alternate buffer and restores it when it switches back to the normal one (by invoking the workbench.action.toggleMaximizedPanel command). I previously discussed this idea at microsoft/vscode-discussions#322.

Thanks!

@Tyriar
Copy link
Member

Tyriar commented Dec 18, 2024

We may add an event like this as part of the buffer API: #207504

So closing in favor of that.

/duplicate

@Tyriar Tyriar closed this as completed Dec 18, 2024
@vs-code-engineering vs-code-engineering bot added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants