Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after removing mono-debug from VSCode help users to install from the marketplace #2083

Closed
weinand opened this issue Jan 18, 2016 · 8 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Jan 18, 2016

Since we will remove mode-debug from VSCode soon, we should help existing users to install mono-debug from the marketplace when they try to run a mono session.

@weinand weinand added feature-request Request for new features or functionality debug Debug viewlet, configurations, breakpoints, adapter issues labels Jan 18, 2016
@weinand weinand added this to the Feb 2016 milestone Jan 18, 2016
@isidorn
Copy link
Contributor

isidorn commented Feb 3, 2016

@jrieken FYI I know you are thinking about proposing extensions, just to make sure we propose mono-debug for mono projects

@weinand what exactly did you have in mind here - help existing users? When we show the mono is missing error that there is an action that takes them to the mono extension in marketplace? Or an action that would automatically install mono? Or something else?

@weinand
Copy link
Contributor Author

weinand commented Feb 3, 2016

@isidorn we should align with what @jrieken is doing for omnisharp.

@isidorn
Copy link
Contributor

isidorn commented Feb 3, 2016

After the standup discussion today I think we came in agreement that once starting the mono session fails we show a nice error message with an action to install mono-debug.
Now what I am not sure is if we should always show this error, or when the user clicks dismiss to never show it again. For our use case I argue we should always show, because it only happens when there is an actual error (user is trying to debug mono) and it should always show when mono is not there and user explicitly wants to debug it.

@isidorn
Copy link
Contributor

isidorn commented Feb 4, 2016

@weinand let me know once you publish the mono-debug to the extension gallery so I can start working on this. If you want I can also remove mono from our vscode and publish it to the gallery, anything works for me 😊

@isidorn
Copy link
Contributor

isidorn commented Feb 4, 2016

@jrieken looks sexy, I'll try it out

@isidorn isidorn closed this as completed in a41236c Feb 4, 2016
@isidorn
Copy link
Contributor

isidorn commented Feb 4, 2016

I am now doing same as Joh once a user tries to start a mono debug session.
Notice that currently nothing will be visible in the UI since the mono-debug extension is not yet in the gallery. I have user andreweinand as publisher and mono-debug as name, since I think we used those in other places, but we can change it.

@weinand
Copy link
Contributor Author

weinand commented Feb 4, 2016

@isidorn you could try to use mock-debug in the meantime.

@isidorn isidorn assigned weinand and unassigned isidorn Feb 26, 2016
@weinand weinand added the verified Verification succeeded label Feb 26, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants