Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to define their own indentation rules within the settings #209805

Open
aiday-mar opened this issue Apr 8, 2024 · 3 comments
Open
Assignees
Labels
editor-autoindent Editor auto indentation issues feature-request Request for new features or functionality

Comments

@aiday-mar
Copy link
Contributor

This feature request derives from #43244 (comment). In that thread, some users have been mentioning they wanted to undo some changes that were made to language configuration files. To help them, we could allow them to edit the indentation rules directly within the settings files.

@aiday-mar aiday-mar self-assigned this Apr 8, 2024
@aiday-mar aiday-mar added editor-autoindent Editor auto indentation issues feature-request Request for new features or functionality labels Apr 8, 2024
@aiday-mar
Copy link
Contributor Author

After discussing with the team, we have come to the conclusion that we do not want to pass on the complexity of the indentation rules to the end user. The indentation rules are quite complicated and if not well thought out by the user, they could cause indentation issues. For now we will not add support for setting overriding, however interested users can create extensions which provide their own language configuration files.

@FlowIT-JIT
Copy link

FlowIT-JIT commented May 6, 2024

@aiday-mar This is absolutely unacceptable. The changes in 1.88.x+ broke the editing experience. Literally broke it. We constantly have to fix broken code now. See #209802

And the new behaviour doesn't align with the explaination in settings:

image

"The editor will keep the current line's indentation"

How 1.88 was accepted as a stable version ready for release is beyond me.

EDIT: Switching to the "Advanced" option actually seems to solve some of the problems introduced in 1.88. I will be testing that.

@aiday-mar
Copy link
Contributor Author

Hi @FlowIT-JIT thank you for expressing your concern, I will look into unindenting the line when a bracket is typed on an indented line after a braceless if/for/while statement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor-autoindent Editor auto indentation issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants