Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore adopting multi file diff editor for notebook diff #224760

Closed
7 of 13 tasks
DonJayamanne opened this issue Aug 5, 2024 · 1 comment
Closed
7 of 13 tasks

Explore adopting multi file diff editor for notebook diff #224760

DonJayamanne opened this issue Aug 5, 2024 · 1 comment
Assignees
Labels
feature-request Request for new features or functionality notebook notebook-diff on-testplan

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Aug 5, 2024

Tasks

Preview Give feedback
@DonJayamanne
Copy link
Contributor Author

DonJayamanne commented Aug 28, 2024

Feature requests for multi file editor widget:

  • Ability to configure an editor as editable (the right hard editor)
    • Currently cell text models are virtual documents (and they are readonly TextResourceEditorModel)
    • Unless we make make some changes to have another instance of BaTextEditorModel thats read-write (based on whether the notebook document is read-write)
  • Custom context for toolbar actions (currently hardcoded to pass uri)
  • Custom collapsible sections (with a hierarchy)
    • Custom borders to clearly distinguish between different cells
  • Toggle white space differences per item (or resource type)
  • Change progress lable from No Changed Files to something else (e.g. Computing Notebook Diffs)
  • Ability to hide/collapse unchanged cells (like unchanged lines)
  • Ability to navigate to an item (even if its currently not visible, required to navigate to next/previous changed cell)
  • Custom editors (webview support in outputs)
  • Diff view ruler

@DonJayamanne DonJayamanne reopened this Aug 28, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality notebook notebook-diff on-testplan
Projects
None yet
Development

No branches or pull requests

1 participant