Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated markdown text to code block #237419

Closed
wants to merge 2 commits into from
Closed

Updated markdown text to code block #237419

wants to merge 2 commits into from

Conversation

mohankumarelec
Copy link
Contributor

Fixes #237418
Closes #237418

joyceerhl
joyceerhl requested changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@joyceerhl joyceerhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CodeblockUriPart is intended to be pushed while already inside a code block. There's some cleanup we can do to make this clearer in the API (which is still proposed and subject to change), but this PR will break current usage.

@mohankumarelec
Copy link
Contributor Author

Thanks @joyceerhl , Got it, will close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyceerhl joyceerhl joyceerhl requested changes

Assignees

@mjbvz mjbvz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vscode.ChatResponseCodeblockUriPart getting rendered as text instead of codeblock pill
3 participants
@mohankumarelec @joyceerhl @mjbvz