Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug editing header of collapsed method #25350

Closed
ghost opened this issue Apr 25, 2017 · 2 comments
Closed

Bug editing header of collapsed method #25350

ghost opened this issue Apr 25, 2017 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) editor-folding Editor code folding issues
Milestone

Comments

@ghost
Copy link

ghost commented Apr 25, 2017

  • VSCode Version: 1.12.0-insider
  • OS Version: Linux Mint 18

Steps to Reproduce:

  1. Paste this code:
class C {
    m() {
        if (true) {
            return;
        }
    }
}
  1. Ctrl-K, Ctrl-0 to collapse all.
  2. Expand class C. (Do not expand the m.)
  3. Click inside the parens in m and write param: number.
  4. An extra ... symbol appears in the middle of the inserted text.

screenshot

@mjbvz mjbvz added the editor-folding Editor code folding issues label Apr 25, 2017
@aeschli
Copy link
Contributor

aeschli commented May 29, 2017

The bug is related to the view model mapping. Hidden markers are mapped to the end of the visible line, but not updated if that line is edited.

  • create the following typescript file
  • collapse m(..): Squiggly is at the end of the line
  • type inside the comment: Squiggly is no longer at the end of the line
class C {
    m(/**/){
        if (true1) {
            return;
        }
    }
}

@aeschli aeschli assigned alexdima and unassigned aeschli May 29, 2017
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Jun 1, 2017
@alexdima alexdima added this to the On Deck milestone Jun 1, 2017
@alexdima
Copy link
Member

This has been fixed in the meantime via #36410

@alexdima alexdima added the *duplicate Issue identified as a duplicate of another issue(s) label Apr 17, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) editor-folding Editor code folding issues
Projects
None yet
Development

No branches or pull requests

3 participants