Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentation actions need big polish #3297

Closed
joaomoreno opened this issue Feb 23, 2016 · 0 comments
Closed

Indentation actions need big polish #3297

joaomoreno opened this issue Feb 23, 2016 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@joaomoreno
Copy link
Member

Testing #3234

I'm having trouble understanding how to use the indentation actions:

  • Indent using Spaces
  • Indent using Tabs

They seem to change how the editor will insert indents from that point forward, without changing the indentation of the content already inside the editor. Not only can this produce mixed indentation files easily but it's only half way to the most common use case: change the file's indentation from one mode to another.

They also seem to produce no visible changes to the editor. Especially if you have a file already indented with tabs, choose Indent using Tabs and select a different tab width than the currently configured one, nothing happens. The file shouldn't change, but the view should adjust to the new tab width.

I suggest to replace both actions with a single Change Indentation Size.

@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Feb 23, 2016
@joaomoreno joaomoreno added this to the Feb 2016 milestone Feb 23, 2016
@joaomoreno joaomoreno changed the title Indentation needs big polish Indentation actions need big polish Feb 23, 2016
@joaomoreno joaomoreno assigned joaomoreno and unassigned isidorn Feb 24, 2016
@joaomoreno joaomoreno added the verified Verification succeeded label Feb 26, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants