Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action buttons are not announced in Explorer section title bar #3310

Closed
stevencl opened this issue Feb 23, 2016 · 1 comment
Closed

Action buttons are not announced in Explorer section title bar #3310

stevencl opened this issue Feb 23, 2016 · 1 comment
Assignees
@stevencl
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
March 2016

Comments

@stevencl
Copy link
Member

Screen reader support turned on and using NVDA.
When focus is on the explorer section title bar (e.g., the title bar showing the name of the open folder) I do not hear the actions being announced as I tab through them. E.g., these actions aren't announced
unannounced

Found when testing #3247
@stevencl stevencl added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Feb 23, 2016
@bpasero bpasero added this to the March 2016 milestone Feb 29, 2016
@bpasero bpasero closed this as completed in 2ec3ac8 Mar 1, 2016
@bpasero bpasero assigned stevencl and unassigned bpasero Mar 1, 2016
@bpasero
Copy link
Member

bpasero commented Mar 1, 2016

Good catch, looks like the view-header has a role of button and thus cannot have buttons within. I changed the role to be "toolbar" now for the view header and it seems to make the buttons announce in NVDA and VoiceOver.

@stevencl stevencl added the verified Verification succeeded label Mar 23, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stevencl stevencl

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
March 2016
Development

No branches or pull requests
2 participants
@bpasero @stevencl