Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No timeout error when timing out due to restart: true #3345

Closed
joaomoreno opened this issue Feb 23, 2016 · 1 comment
Closed

No timeout error when timing out due to restart: true #3345

joaomoreno opened this issue Feb 23, 2016 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues important Issue identified as high-priority polish Cleanup and polish issue verified Verification succeeded
Milestone

Comments

@joaomoreno
Copy link
Member

Testing #3238

While successfully debugging using restart: true and nodemon, I created a syntax error and waited. The debugger eventually stopped attempting to connect after 10 seconds. There was no UI error indicating what happened. The console did have errors though.

image

Note that the error does appear on an initial failed attach attempt:

image

@joaomoreno joaomoreno added debug Debug viewlet, configurations, breakpoints, adapter issues polish Cleanup and polish issue labels Feb 23, 2016
@weinand weinand added the important Issue identified as high-priority label Feb 24, 2016
@joaomoreno joaomoreno modified the milestone: Feb 2016 Feb 24, 2016
@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Feb 25, 2016
@weinand weinand assigned isidorn and unassigned weinand Feb 25, 2016
@weinand
Copy link
Contributor

weinand commented Feb 25, 2016

@isidorn I've debugged this and it seems that errors returned from 'attach' are only shown in the UI if it is the first 'attach' and not a restarted 'attach'. I tried to find a 'filter' in your code that prevents these error from being shown, but I wasn't successful. Do you have an idea why these errors are not showing up?

@isidorn isidorn assigned joaomoreno and unassigned isidorn Feb 25, 2016
@joaomoreno joaomoreno added the verified Verification succeeded label Feb 26, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues important Issue identified as high-priority polish Cleanup and polish issue verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants