Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nls: align config and loadMessageBundle calls #3397

Closed
joaomoreno opened this issue Feb 24, 2016 · 2 comments
Closed

Nls: align config and loadMessageBundle calls #3397

joaomoreno opened this issue Feb 24, 2016 · 2 comments
Assignees
@dbaeumer
Labels
polish Cleanup and polish issue upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded

Comments

@joaomoreno
Copy link
Member

Testing #3156

When using vscode-nls, I have to call nls.config() in one file and loadMessageBundle in all the others. Couldn't we align this such that I don't need to track whether I have called nls.config() in one of my files at all?

Eg: just calling nls.config() in all files would fix it for me.
@joaomoreno joaomoreno added the polish Cleanup and polish issue label Feb 24, 2016
@joaomoreno joaomoreno changed the title Nls: align config and loadMessageBundle calls Nls: align config and loadMessageBundle calls Feb 24, 2016
@dbaeumer
Copy link
Member

I am pretty sure that this is already possible. But need to check.

@dbaeumer dbaeumer mentioned this issue Feb 29, 2016
Closed
@dbaeumer
Copy link
Member

This issue was moved to microsoft/vscode-nls#6

@dbaeumer dbaeumer added upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded labels May 27, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dbaeumer dbaeumer

Labels
polish Cleanup and polish issue upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joaomoreno @dbaeumer