Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish task snippets #3416

Closed
joaomoreno opened this issue Feb 24, 2016 · 2 comments
Closed

Polish task snippets #3416

joaomoreno opened this issue Feb 24, 2016 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue verified Verification succeeded
Milestone

Comments

@joaomoreno
Copy link
Member

Related to #3159 #3413

As discussed in triage, I reverted commits 8004d27, b7e9c82 and a7a0f82 which introduced snippet support for tasks.json. The reverts are: 9d64fe7, 9c5cefb and 856fb0b.

The experience needs to be improved, the user needs more guidance towards creating a final, working tasks.json file.

Joao Moreno [15:08]:
hi Erich?
Erich Gamma [15:08]:
hi
Joao Moreno [15:08]:
sorry to bug you
Erich Gamma [15:08]:
no prob
i'm working anyways
Joao Moreno [15:09]:
i have a feeling Dirk left his task stuff halfway done: #3159
it's very hard now to generate a tasks file. I even went through our documentation and couldn't figure it out
meaning: I tried setting up a build task with the ts compiler, and still didn't make it. maybe this needs more thought?
Erich Gamma [15:11]:
This definitely came in hot. I have never used it end to end and only looked at the point feature, which made sense.
Joao Moreno [15:11]:
got it
Erich Gamma [15:11]:
Let me give it a try as well
Joao Moreno [15:12]:
please do. if you feel the same, I propose to undo it and polish it when dirk is back
Erich Gamma [15:12]:
agreed, I'll get back to you
Joao Moreno [15:12]:
thanks!
Erich Gamma [15:31]:
Tried and I got it to work, but there are issues and I suggest to rollback and revisit the experience.
I'll file an issue
unless there already is one
Joao Moreno [15:34]:
there isn't one for rolling back, no
just small ones for the isolated hickups in the experience
Erich Gamma [15:36]:
ok, then this is good enough and I suggest that you discuss this in the triage and suggest to roll back the change, since Dirk cannot address the hickups and you have my support for this.
Joao Moreno [15:36]:
thanks!

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue labels Feb 24, 2016
@joaomoreno joaomoreno added this to the March 2016 milestone Feb 24, 2016
@dbaeumer
Copy link
Member

dbaeumer commented Mar 1, 2016

Discussed with Joao the concerns he raised and demoed him and Erich the new implementation.

@dbaeumer dbaeumer closed this as completed Mar 1, 2016
@dbaeumer dbaeumer added the verified Verification succeeded label Mar 21, 2016
@dbaeumer
Copy link
Member

Marking as verified since the story got obsolete.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants