Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel and viewlet on right should have a border between them #37373

Closed
Tyriar opened this issue Nov 1, 2017 · 3 comments
Closed

Panel and viewlet on right should have a border between them #37373

Tyriar opened this issue Nov 1, 2017 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality layout General VS Code workbench layout issues themes Color theme issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Nov 1, 2017

  • VSCode Version: Code - Insiders 1.18.0-insider (8dfa696, 2017-10-31T16:36:35.429Z)
  • OS Version: Linux x64 4.10.0-26-generic
  • Extensions:
Extension Author (truncated) Version
EditorConfig Edi 0.11.1
lorem-ipsum Tyr 1.0.0
shell-launcher Tyr 0.1.4
vscode-terminal-here Tyr 0.0.5
vscode-svgviewer css 1.4.3
tslint eg2 1.0.14
git-project-manager fel 1.4.0
md-navigate jri 0.0.1
vscode-rust kal 0.4.2
vscode-scss mrm 0.6.2
cpptools ms- 0.14.0
seti-icons qin 0.1.3

(3 theme extensions excluded)


#36906

Some themes separate the color of the workbench from the editor, if the panel and viewlet are the same color then it's hard to tell where the split is:

image

@vscodebot vscodebot bot added the insiders label Nov 1, 2017
@isidorn isidorn added this to the October 2017 milestone Nov 1, 2017
@bpasero
Copy link
Member

bpasero commented Nov 1, 2017

I am not sure I would agree because this heavily depends on the theme, e.g. it is fine in dark theme:

image

In any case this probably needs a new theme color key. Note that we already (unfortunately) have panel.border which is for separating to the editor area. We probably need another key for separating to the side (only if the side bar is on the right actually).

image

@isidorn
Copy link
Contributor

isidorn commented Nov 1, 2017

@bpasero agree this is theme dependent. Let's wait for users to complain before I introduce a new color and then we can allow themes to customize this.

@isidorn isidorn modified the milestones: October 2017, Backlog Nov 1, 2017
@isidorn isidorn added feature-request Request for new features or functionality and removed insiders labels Nov 1, 2017
@bpasero bpasero added layout General VS Code workbench layout issues themes Color theme issues and removed workbench labels Nov 16, 2017
@isidorn
Copy link
Contributor

isidorn commented Jun 5, 2018

After looking deeper into this, we already have a color which does just this nicely
"sideBar.border"

This issue in general is panel independent since the sidebar can have the same color as the editor and then the border is needed, which gets tackled by the above mentioned color.

Closing since this works nicely imho

@isidorn isidorn closed this as completed Jun 5, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality layout General VS Code workbench layout issues themes Color theme issues
Projects
None yet
Development

No branches or pull requests

3 participants