Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool to generate/update a language pack from transifex #41682

Closed
aeschli opened this issue Jan 16, 2018 · 10 comments
Closed

Tool to generate/update a language pack from transifex #41682

aeschli opened this issue Jan 16, 2018 · 10 comments
Assignees
Labels
feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming verified Verification succeeded
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Jan 16, 2018

Create an extension for a new language:

  • Initialized from translations from transifex
  • Contains a script to update (and republish)
@aeschli aeschli added this to the January 2018 milestone Jan 16, 2018
@aeschli aeschli self-assigned this Jan 16, 2018
@aeschli
Copy link
Contributor Author

aeschli commented Jan 18, 2018

@aeschli
Copy link
Contributor Author

aeschli commented Jan 18, 2018

@dbaeumer Dirk can you comment on the file format?

@dbaeumer
Copy link
Member

File format looks good to me.

@aeschli
Copy link
Contributor Author

aeschli commented Jan 19, 2018

I updated the code yeoman generator to contain a 'languagePack' option.

-> npm install -g generator-code@next

To fetch & update language strings, the language pack must be placed next to the vscode repo on the dbaeumer/39178 branch

@aeschli
Copy link
Contributor Author

aeschli commented Jan 22, 2018

vscode-localization-hu-0.0.1.vsix.txt

@dbaeumer @sandy081 Latest format after discussions with @sandy081.

-> Use localization instead of language pack everywhere
-> localizations contribution point:

    "contributes": {
        "localizations": [
            {
                "languageId": "hu",
                "languageName": "Hungarian",
                "translations": "./translations"
            }
        ]
    }

@aeschli
Copy link
Contributor Author

aeschli commented Jan 23, 2018

vscode-localization-hu-0.0.1.vsix.txt

translation files without comments..

@aeschli
Copy link
Contributor Author

aeschli commented Jan 23, 2018

vscode-localization-hu-0.0.1.vsix.txt

Files with version and 'contents' property...

{
	"": [
		"--------------------------------------------------------------------------------------------",
		"Copyright (c) Microsoft Corporation. All rights reserved.",
		"Licensed under the MIT License. See License.txt in the project root for license information.",
		"--------------------------------------------------------------------------------------------",
		"Do not edit this file. It is machine generated."
	],
	"version": "1.0.0",
	"contents": {
		"vs/platform/actions/electron-browser/menusExtensionPoint": {
			"requirearray": "a menüelemeket tömbként kell megadni",
   ...

@aeschli aeschli added feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming labels Jan 26, 2018
@dbaeumer
Copy link
Member

@aeschli the vsix seems to be incomplete. For example the bundle for git only contains translations for the package but not for other files. Can you please have a look and attach a new one

@aeschli
Copy link
Contributor Author

aeschli commented Jan 30, 2018

vscode-language-pack-pt-br-0.0.1.vsix.txt

Updated VSIX (with all git resources)

@aeschli
Copy link
Contributor Author

aeschli commented Jan 30, 2018

vscode-language-pack-ps-0.0.1.vsix.txt

Updated VSIX (with all git resources)

@aeschli aeschli closed this as completed Feb 1, 2018
@aeschli aeschli added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants