Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Extension list items in the installed extensions treeview are in the tab order. #51496

Closed
auchenberg opened this issue Jun 8, 2018 · 10 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Milestone

Comments

@auchenberg
Copy link
Contributor

Learnings from NVAccess testing:

Items in the installed extensions treeview are in the tab order. This is not necessary as you can get to them by using the arrow keys when focused on the treeview. Having them in the tab order makes keyboard navigation very innefficient

@auchenberg auchenberg added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Jun 8, 2018
@sandy081 sandy081 assigned ramya-rao-a and unassigned sandy081 Jun 11, 2018
@ramya-rao-a
Copy link
Contributor

There are multiple actions for each item in the extension list

  • Click on item opens extension details in an editor
  • Click on Install button (for uninstalled extension) or the Manage button (for installed extension).
  • Click on Reload button
  • Click on Update button along with Manage button

So we need to have these buttons in the tab order.
If we remove them from the tab order, how can they every be reached?

@ramya-rao-a ramya-rao-a added info-needed Issue requires more information from poster extensions Issues concerning extensions labels Jun 11, 2018
@vscodebot vscodebot bot closed this as completed Jun 18, 2018
@vscodebot
Copy link

vscodebot bot commented Jun 18, 2018

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@auchenberg
Copy link
Contributor Author

auchenberg commented Jun 18, 2018

Reopening, as we are awaiting on more info from NVAccess.

@auchenberg auchenberg reopened this Jun 18, 2018
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jun 19, 2018

Expected behaviour:

  • From the search box, tab should give focus to the entire extensions list (even if one of the list items are selected). Next tab should take us out of the viewlet and into the editor space.
  • From the search box, tab should give focus to the entire extensions list. Arrow keys from this point can be used to traverse the list.
  • From the search box arrow keys can be used to traverse the list. (Fixed with Down arrow moves focus to extensions list #53616)
  • Once a list item has focus
    • Enter/Space on any list item should open the extensions editor
    • Tab at this point will go trough the actionable items in the item (Install/Update/Reload/Manage etc)
    • Arrow keys will still let you traverse the list

Open question:

  • What should happen when we press tab after the last action item in the list item has focus?

cc @misolori

@ramya-rao-a ramya-rao-a removed the info-needed Issue requires more information from poster label Jun 19, 2018
@ramya-rao-a ramya-rao-a added this to the June 2018 milestone Jun 19, 2018
@miguelsolorio
Copy link
Contributor

@ramya-rao-a if I’m on the last actionable item and hit tab, I would expect to go to the beginning of the actionable items.

@JacksonKearl
Copy link
Contributor

We currently have no support for dynamically updating tab indices as this would require. It could be done, but would require opening up the action bar and action item interfaces. Not sure if thats something we want to do.

@ramya-rao-a ramya-rao-a added the bug Issue identified by VS Code Team member as probable bug label Sep 12, 2018
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, September 2018 Sep 12, 2018
@ramya-rao-a
Copy link
Contributor

As per #59280 (comment), moving this to October.

@ramya-rao-a
Copy link
Contributor

Fixed with f3eb7ad

@chrmarti
Copy link
Collaborator

chrmarti commented Nov 1, 2018

Not working as described as expected behavior above:

  • "From the search box arrow keys can be used": Up/down arrow keys don't do anything when in the search box.
  • "Enter/Space on any list item should open the extensions editor": Space doesn't open the editor.
  • "If I’m on the last actionable item and hit tab, I would expect to go to the beginning of the actionable items.": It goes to the next section, which appears to be fine, because that's more consistent with general Tab behavior.

Marking for verification steps needed.

@chrmarti chrmarti added the verification-steps-needed Steps to verify are needed for verification label Nov 1, 2018
@ramya-rao-a
Copy link
Contributor

Verification Steps:

  • From the search box, Ctrl+down-arrow (Cmd+down-arrow in Mac) to step into the list just like the Search Viewlet. From there on up and down arrow to traverse the list
  • From the search box, tabbing shouldnt go over list items or the actionable items in the list items
  • When Focus is on any item, Enter opens extension editor
  • When Focus is on any item, tab moves focus to the actionable item in the item

@ramya-rao-a ramya-rao-a removed the verification-steps-needed Steps to verify are needed for verification label Nov 1, 2018
@chrmarti chrmarti added the verified Verification succeeded label Nov 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants