Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix settings search to not be implemented via an ITextModel #55792

Closed
roblourens opened this issue Aug 3, 2018 · 0 comments
Closed

Fix settings search to not be implemented via an ITextModel #55792

roblourens opened this issue Aug 3, 2018 · 0 comments
Assignees
@roblourens
Labels
engineering VS Code - Build / issue tracking / etc. settings-editor VS Code settings editor issues
Milestone
September 2018

Comments

@roblourens
Copy link
Member

roblourens commented Aug 3, 2018 •
edited
Loading

The new settings UI is backed by an EditorModel and ITextModel even though there is no text editor involved. Currently local settings search goes through the AbstractSettingsModel, only for searching in values. But we can search values the same way that the other setting fields are searched.

Not causing a specific problem, but also not "right".
@roblourens roblourens added settings-editor VS Code settings editor issues engineering VS Code - Build / issue tracking / etc. labels Aug 3, 2018
@roblourens roblourens self-assigned this Aug 3, 2018
@roblourens roblourens mentioned this issue Aug 3, 2018
Closed
38 tasks
@roblourens roblourens changed the title Fix settings search to not be implemented via an EditorModel Fix settings search to not be implemented via an ITextModel Sep 6, 2018
@roblourens roblourens added this to the September 2018 milestone Sep 9, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
engineering VS Code - Build / issue tracking / etc. settings-editor VS Code settings editor issues
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
1 participant
@roblourens