Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conpty: Terminal rendering very slow with huge output #84137

Closed
GoaLitiuM opened this issue Nov 7, 2019 · 3 comments
Closed

Conpty: Terminal rendering very slow with huge output #84137

GoaLitiuM opened this issue Nov 7, 2019 · 3 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@GoaLitiuM
Copy link

GoaLitiuM commented Nov 7, 2019

Conpty renders terminal window almost unusable when a compiler suddenly emits hundreds of hundreds of error lines.

For example, running tree /F in my dev folder took this long to finish:

  • ~12sec in Command Prompt
  • ~11sec in VSCode without Conpty
  • ~65sec in VSCode with Conpty

Renderer type has minor difference to the execution speed where DOM being slightly slower, but these were observed with Canvas rendering enabled.

Steps to Reproduce:

  1. Enable Conpty.
  2. Run a command which produces lots of lines (like tree C: /F)
  3. Repeat without Conpty and observe how much longer it takes to finish the command.
  • VSCode Version: 1.39.2
  • OS Version: Windows 10 build 18362

Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Nov 7, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@Tyriar
Copy link
Member

Tyriar commented Nov 8, 2019

Speed should improve somewhat in 1.40 but the root cause of this is #74620

/duplicate

@Tyriar Tyriar closed this as completed Nov 8, 2019
@vscodebot vscodebot bot added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 8, 2019
@GoaLitiuM
Copy link
Author

Confirmed, 1.40 has similar performance between those two modes. Thanks.

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants