Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only generate valid document links of @use and @forward imports #85980

Closed
octref opened this issue Dec 2, 2019 · 2 comments
Closed

Only generate valid document links of @use and @forward imports #85980

octref opened this issue Dec 2, 2019 · 2 comments
Assignees
@octref
Labels
bug Issue identified by VS Code Team member as probable bug css-less-scss Issues and items concerning CSS,Less,SCSS styling verified Verification succeeded
Milestone
November 2019

Comments

@octref
Copy link
Contributor

octref commented Dec 2, 2019 •
edited
Loading

Ref #81943, #85979

@use "material";
@use "material/theme";

Both cases should provide no links since they don't point to actual paths.

EDIT: Seems link verification has been broken.
Verify that @use "./foo.scss" doesn't generate a link when ./foo.scss doesn't exist on disk.
@octref octref added bug Issue identified by VS Code Team member as probable bug css-less-scss Issues and items concerning CSS,Less,SCSS styling labels Dec 2, 2019
@octref octref added this to the November 2019 milestone Dec 2, 2019
@octref octref self-assigned this Dec 2, 2019
@octref octref changed the title Valid links of @use and @forward imports, and link std libraries to official documentation Only generate valid document links of @use and @forward imports Dec 2, 2019
@mjbvz mjbvz added verified Verification succeeded verification-found Issue verification failed and removed verified Verification succeeded labels Dec 4, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented Dec 4, 2019

Still seeing this with 7f1975a

Screen Shot 2019-12-04 at 3 06 13 PM

@mjbvz mjbvz reopened this Dec 4, 2019
@octref
Copy link
Contributor Author

octref commented Dec 5, 2019

Sorry, forgot to pull in CSS dependency...

@octref octref removed the verification-found Issue verification failed label Dec 5, 2019
@octref octref closed this as completed Dec 5, 2019
@jrieken jrieken added the verified Verification succeeded label Dec 5, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@octref octref

Labels
bug Issue identified by VS Code Team member as probable bug css-less-scss Issues and items concerning CSS,Less,SCSS styling verified Verification succeeded
Projects
None yet
Milestone
November 2019
Development

No branches or pull requests
3 participants
@jrieken @octref @mjbvz