Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow JSDOMParser to be loaded as a "proper" CommonJS module #346

Open
gijsk opened this issue Jan 23, 2017 · 3 comments
Open

Allow JSDOMParser to be loaded as a "proper" CommonJS module #346

gijsk opened this issue Jan 23, 2017 · 3 comments
Labels
maintenance

Comments

@gijsk
Copy link
Contributor

gijsk commented Jan 23, 2017

After PR #340 addressing the summary of this issue should be sufficient to make this a more node-y set of code, facilitating more sharing/improvements by consumers other than Firefox.
@gijsk gijsk mentioned this issue Jan 23, 2017
Merged
@gijsk
Copy link
Contributor Author

gijsk commented Jan 23, 2017

Note that we should then also update the ReadMe to stop recommending JSDOMParser. It's not what people want in about 99% of cases.

@gijsk gijsk mentioned this issue Dec 5, 2017
Closed
@davidar davidar mentioned this issue Apr 22, 2018
Merged
@gijsk
Copy link
Contributor Author

gijsk commented Apr 29, 2018

Updating given we merged #438.

@luxifer
Copy link

luxifer commented May 9, 2018

I can confirm that the dependency on JSDOMParser is now useless to get these constants. See https://github.com/luxifer/readability-api

@gijsk gijsk changed the title Allow JSDOMParser to be loaded as a "proper" CommonJS module, and stop Readability depending on Node.* constants Allow JSDOMParser to be loaded as a "proper" CommonJS module Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gijsk @luxifer