-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gesture handler not working with ui-chart on ios #18
Comments
@farfromrefug Let me know if you need further information |
@nc1401 i cant fix it just like that. Please share a very simple repro example (not angular please). |
@farfromrefug here is the sample for this issue. `public onLineChartLoaded({ object: lineChart }: { object: LineChart }): void {
} // used for Line chart styles
}` |
@hg071 Please share a complete project so I can download and run it and see the error. a project zip file or a repository would be fine |
@farfromrefug @vallemar Here is the folder structure and project zip file. Folder structure : |
@hg071 i cant run your project. Yarn is not even able to install correctly with Nx. Could you create a simple project without nx? |
@farfromrefug Please consider it as pseudocode and check the function implementation for charts. |
@hg071 i am sorry but i dont do angular so wont be straightforward. Plus i dont really have the time to do it. I have my job + maintaining more than 50 plugins takes a lot of time. Sorry but without your help i wont be able to look at this anytime soon. |
Summary
I am using @nativescript-cummunity/ui-chart to display a line chart in my application, it seems to work out in android seamlessly, for IOS though, I have to refresh my screen twice for my chart to be visible and once it appears I am not able to tap or drag on the chart.
This is the error I keep seeing :
NS error log:{"type":"JavaScript","message":"this.manager.registerGestureHandler is not a function","stack":"TypeError: this.manager.registerGestureHandler is not a function\n at Manager.attachGestureHandler (file:///app/vendor.js:6169:22)\n at TapHandler.attachToView (file:///app/vendor.js:5971:28)\n at BarLineChartTouchListener.setTap (file:///app/vendor.js:17827:49)\n at LineChart.setHighlightPerTapEnabled (file:///app/vendor.js:11637:48)\n at ChartsComponent.createLineChart (file:///app/bundle.js:2209:22)\n at ChartsComponent.onLineChartLoaded (file:///app/bundle.js:2148:14)\n at ChartsComponent__chart_LineChart_3_Template__chart_LineChart_loaded_0_listener (file:///app/bundle.js:1993:386)\n at executeListenerWithErrorHandling (file:///app/vendor.js:139587:12)\n at Object.wrapListenerIn_markDirtyAndPreventDefault (file:///app/vendor.js:139618:18)\n at _ZoneDelegate.invokeTask (file:///app/vendor.js:103604:31)"}
P.S
this is only an issue with GestureHandler version > 2.0.12, I have 2 repos, it seems to work where my GestureHandler version is 2.0.12, it does not work for the second repo where version is 2.0.24/2.0.28. This version is controlled by ui-chart automatically.
Also, if I remove the below lines which are essentially calling for gesture handler, the issue goes away but then I don't have the functionality for tap or drag:
this.lineRef.setHighlightPerTapEnabled(true);
this.lineRef.setHighlightPerDragEnabled(true);
Expected Behaviour:
Chart should be visible at all times and gestures should be enabled.
Device (please complete the following information):
Device: Iphone 15 pro, pro max, iphone 13
Ios version : 17.0.2, 15.0.0
Library Version :
ui-chart : 1.2.28/1.2.32/1.2.35
gestureHandler: 2.0.24/2.0.28
The text was updated successfully, but these errors were encountered: