bug: Unable to add additional configuration to Himalaya accounts

[rprospero]

Are you following the right branch?

• My Nixpkgs and Home Manager versions are in sync

Is there an existing issue for this?

• I have searched the existing issues

Issue description

My work e-mail uses Office365 and requires OAUTH2. With Himalaya, I can configure this with

[acounts.work]
smtp.oauth2.method = "xoauth2"
# Much oauth configuration to follow

I have tried adding the corresponding configuration to my home manager config

programs.himalaya.settings.accounts.work.smtp.oauth2.method = "xoauth2";

Unfortunately, the oauth2 settings do not appear in the generated config file. In fact, nothing from programs.himalaya.settings.accounts is included in the final file. The issue appears to stem from line 172 of modules/programs/himalaya.nix, where an attrset merge overwrites the accounts settings. If this was replaced with a call to lib.attrsets.recursiveUpdate, I believe that it should be possible to add additional account data while still pulling in the main information from the general accounts.email.accounts section.

I am happy to submit a PR for this change, but I wanted to confirm that this was a bug and not intended behaviour before I continued.

Maintainer CC

@soy

System information

- system: `"x86_64-linux"`
 - host os: `Linux 6.6.32, NixOS, 24.05 (Uakari), 24.05.20240606.9b5328b`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.2`
 - channels(root): `"nixos-22.05"`
 - channels(adam): `"nixpkgs-22.11, nixpkg-22.11"`
 - nixpkgs: `/home/adam/.nix-defexpr/channels/nixpkgs`