Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop RequestStore in favor of ActiveSupport::CurrentAttributes #1444

Open
raszi opened this issue Oct 6, 2023 · 10 comments · May be fixed by #1447
Open

Drop RequestStore in favor of ActiveSupport::CurrentAttributes #1444

raszi opened this issue Oct 6, 2023 · 10 comments · May be fixed by #1447

Comments

@raszi
Copy link

raszi commented Oct 6, 2023

Is your feature suggestion related to a problem? Please describe.

The gem is already depending on activerecord and activerecord depends on activesupport. In activesupport there is a feature called ActiveSupport::CurrentAttributes. That feature is available since Rails 5.2, so quite a while ago.

To reduce the number of dependencies and the different implementations, you could switch from using request_store to only activerecord and maybe a direct dependency to activesupport.

Describe the solution you'd like to build

Switch from request_store to activesupport to store request related attributes.

Describe alternatives you've considered

Keeping the RequestStore dependency as it is.
@raszi
Copy link
Author

raszi commented Oct 6, 2023

This issue is also related: steveklabnik/request_store#85

@joshuay03 joshuay03 linked a pull request Nov 16, 2023 that will close this issue
Open
6 tasks
@joshuay03
Copy link

joshuay03 commented Nov 17, 2023 •
edited
Loading

Hello 👋🏽 I got this up as a POC: #1447

@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale due to inactivity.
The resources of our volunteers are limited.
Bug reports must provide a script that reproduces the bug, using our template. Feature suggestions must include a promise to build the feature yourself.
Thank you for all your contributions.

@github-actions github-actions bot added the Stale label Feb 16, 2024
@joshuay03
Copy link

Poke.

@github-actions github-actions bot removed the Stale label Feb 17, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale due to inactivity.
The resources of our volunteers are limited.
Bug reports must provide a script that reproduces the bug, using our template. Feature suggestions must include a promise to build the feature yourself.
Thank you for all your contributions.

@github-actions github-actions bot added the Stale label May 17, 2024
@joshuay03
Copy link

Poke Bowl.

@github-actions github-actions bot removed the Stale label May 18, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale due to inactivity.
The resources of our volunteers are limited.
Bug reports must provide a script that reproduces the bug, using our template. Feature suggestions must include a promise to build the feature yourself.
Thank you for all your contributions.

@github-actions github-actions bot added the Stale label Aug 16, 2024
@joshuay03
Copy link

joshuay03 commented Aug 16, 2024 •
edited
Loading

Pocahontas.

@github-actions github-actions bot removed the Stale label Aug 17, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale due to inactivity.
The resources of our volunteers are limited.
Bug reports must provide a script that reproduces the bug, using our template. Feature suggestions must include a promise to build the feature yourself.
Thank you for all your contributions.

@github-actions github-actions bot added the Stale label Nov 15, 2024
@jagthedrummer
Copy link

Not stale.

@github-actions github-actions bot removed the Stale label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop RequestStore in favour of ActiveSupport::CurrentAttributes joshuay03/paper_trail
3 participants
@jagthedrummer @raszi @joshuay03