RegExp.prototype.flags cannot be read in Chrome Canary

[fizker]

One of the shims adds a getter for RegExp.prototype.flags, and guards against overriding the native by reading the current value.

But reading RegExp.prototype.flags throws an error in Chrome Canary (48.0.2559.0): Uncaught TypeError: RegExp.prototype.global getter called on non-RegExp object.

Note: Chrome Canary requires the Experimental JavaScript flag to be enabled before exposing RegExp.prototype.flags.

[mathiasbynens]

That matches the spec. The error message summarizes it well.

[fizker]

The problem is that our webapp breaks in es6-shim because it tries to test whether or not to shim the feature

[ljharb]

@fizker this is indeed part of the spec - you'll need to use typeof Object.getOwnPropertyDescriptor(RegExp.prototype, 'flags').get !== 'function' to detect it.

[fizker]

@ljharb No, technically you need to use that :P. I have made a PR with it

[ljharb]

ha, touché. i haven't yet updated things to pass in Chrome Canary. Thanks for the PR.

[ljharb]

Fixed in c563abf

[fizker]

Perfect :). Do you know when this will get released? I would prefer to get it into production as soon as possible, as the crash was rather nasty.

[ljharb]

I will release it shortly, but it's Chrome Canary - nobody using a canary build should have any expectation of any site working. Chrome Stable won't release with it for many weeks.

[fizker]

Still, I would prefer having more time for testing, as we are not on the newest es6-shim. If I am not mistaken, we are still on a version that uses String#contains rather than String#includes, so a lot of other things could also be breaking changes. Anyway, thanks for the quick turn-around on this issue :)

[ljharb]

aha, that's a very very old version indeed - you will want to upgrade soon. I'll have v0.33.11 out today.

[ljharb]

All set https://github.com/paulmillr/es6-shim/releases/tag/0.33.11

[fizker]

Nice! Thanks :)