Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set/get ngFor performance on IE11 #422

Closed
aronallen opened this issue Aug 9, 2016 · 3 comments
Closed

set/get ngFor performance on IE11 #422

aronallen opened this issue Aug 9, 2016 · 3 comments
Labels
Collections: Map / Set / WeakMap / WeakSet IE Performance pull request wanted

Comments

@aronallen
Copy link

aronallen commented Aug 9, 2016 •
edited
Loading

Hi,

We are having this issue in Angular 2 land.
Any chance shim performance can be improved for IE11.

angular/angular#8112

The code is constantly calling isNan function in es6-shim.js.
The problem seems to be due to the reason that set and get functions of the polyfill are extremely slow (compared to their native counterparts) and take most of the time.
@aronallen aronallen changed the title set/get ngFor performance bottleneck on IE11 set/get ngFor performance on IE11 Aug 9, 2016
@ljharb
Copy link
Collaborator

ljharb commented Aug 9, 2016

I'd be happy to improve performance wherever it can be done without sacrificing correctness.

I'm not sure what the best way to do that is, but am open to PRs.

@jdalton
Copy link
Contributor

jdalton commented Nov 19, 2016 •
edited
Loading

I'll give a PR a try 😀 (#429)

@jdalton jdalton mentioned this issue Nov 21, 2016
Merged
@ljharb
Copy link
Collaborator

ljharb commented Dec 4, 2016

@aronallen #429 is released with v0.35.2 - please let me know if that does not resolve your performance issue.

@ljharb ljharb closed this as completed Dec 4, 2016
@hartmutobendorf hartmutobendorf mentioned this issue Jul 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Collections: Map / Set / WeakMap / WeakSet IE Performance pull request wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdalton @ljharb @aronallen