Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also disable wireless adb when finished #2

Open
radioaddition opened this issue Oct 18, 2024 · 4 comments
Open

Also disable wireless adb when finished #2

radioaddition opened this issue Oct 18, 2024 · 4 comments
Assignees
Labels
question Further information is requested

Comments

@radioaddition
Copy link

Seems like it'd be better security-wise that if you're automatically enabling wireless adb to start the service that it'd also be a good idea to disable it when the service is started

@pixincreate
Copy link
Owner

i do not think it will matter. here's why:

  • the moment wifi is disabled, wireless debuggin turns itself off
  • and when connected to different wifi networks, you'll receive a prompt the moment you toggle wireless debugging which requires user interaction

so yeah, this new addition imo is redundant

@pixincreate pixincreate added the question Further information is requested label Oct 18, 2024
@BRBsoup
Copy link

BRBsoup commented Nov 26, 2024

i do not think it will matter. here's why:

  • the moment wifi is disabled, wireless debuggin turns itself off
  • and when connected to different wifi networks, you'll receive a prompt the moment you toggle wireless debugging which requires user interaction

so yeah, this new addition imo is redundant

I emailed you but repesting here, basically just wanted to point out this commit, perhaps it's a good idea (AccessibilityService to auto-confirm wifi debugging):

5ac0cdf

@pixincreate
Copy link
Owner

will consider adding accessibility service implementation for auto enabling the prompt.

but yeah, the initial pairing to wireless adb has to be manually done by the user.

@BRBsoup
Copy link

BRBsoup commented Nov 26, 2024

will consider adding accessibility service implementation for auto enabling the prompt.

but yeah, the initial pairing to wireless adb has to be manually done by the user.

Thanks for being receptive and for explaining that. Again, your repo here is an excellent asset 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants