Add hasBorder prop to pillar and increase border radius on Card #880
Conversation
🦋 Changeset detectedLatest commit: 6a64362 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟢 No design token changes found |
| @@ -67,6 +67,20 @@ You can add an image to enhance the visual context. | |||
| </Pillar> | |||
| ``` | |||
|
|
|||
| ### Border | |||
|
|
|||
| You can add an optional border to create a visual boundary around the pillar content. | |||
There was a problem hiding this comment.
@jesussandreas Is this okay or do you want to elaborate on why / when users should apply a border?
There was a problem hiding this comment.
This should be fine for the React docs, but we may want to update the interface guidelines to include some guidance on when to apply borders. We can address this as a follow-up.
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
| @@ -67,6 +67,20 @@ You can add an image to enhance the visual context. | |||
| </Pillar> | |||
| ``` | |||
|
|
|||
| ### Border | |||
|
|
|||
| You can add an optional border to create a visual boundary around the pillar content. | |||
There was a problem hiding this comment.
This should be fine for the React docs, but we may want to update the interface guidelines to include some guidance on when to apply borders. We can address this as a follow-up.
Summary
Closes #816
Closes #874
Part of https://github.com/github/primer/issues/4601
🔗 Docs
🔗 Storybook
List of notable changes:
hasBorderprop to Pillar per designWhat should reviewers focus on?
Steps to test:
🔗 Documentation
🔗 Storybook example
Supporting resources (related issues, external links, etc):
Contributor checklist:
update snapshotslabel to the PR)Reviewer checklist:
Screenshots:
Card
Pillar