Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendered examples are cut off in documentation #820

Closed
trosage opened this issue Jun 11, 2019 · 2 comments
Closed

Rendered examples are cut off in documentation #820

trosage opened this issue Jun 11, 2019 · 2 comments

Comments

@trosage
Copy link
Contributor

trosage commented Jun 11, 2019

In numerous areas where rendered examples are shown for Primer styles the height is cut short cropping the example. Here are a couple of screenshots:

Forms docs
image

image

@combizs
Copy link

combizs commented Aug 16, 2019

@trosage, at a glance from what I've gathered, when the components are rendered and the iframe is resized, the computed height of the elements rendered does not account for the margins necessary.

@simurai
Copy link
Contributor

simurai commented Dec 31, 2019

@combizs at a glance from what I've gathered, when the components are rendered and the iframe is resized, the computed height of the elements rendered does not account for the margins necessary.

Right. Examples are rendered in iframes and the height doesn't take fixed/absolutely positioned elements into account. In #725 we fixed it by manually adding padding or fixed height. Gonna close this again, but feel free to reopen if you find more examples.

@simurai simurai closed this as completed Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants