From 729a16161615c16def3ba2b2301450661d076974 Mon Sep 17 00:00:00 2001 From: Hector Palacios Date: Fri, 23 Apr 2021 18:52:58 +0200 Subject: [PATCH 1/4] typography-base: process 'type' attribute of HTML
    tag Some markup languages like AsciiDoc, allow defining the 'type' attribute of HTML
      tag. For instance, the following AsciiDoc code: [loweralpha] . item1 . item2 Produces in GitHub the HTML code:
      1. item1
      2. item2
      The current SCSS doesn't cover this 'type' attribute, so the regular default symbol (decimal) applies, instead of the one intended by the author. Signed-off-by: Hector Palacios --- src/base/typography-base.scss | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/base/typography-base.scss b/src/base/typography-base.scss index 83eb995279..07fc94dccd 100644 --- a/src/base/typography-base.scss +++ b/src/base/typography-base.scss @@ -58,6 +58,18 @@ ol ol ol { list-style-type: lower-alpha; } +ol[type="1"] { + list-style-type: decimal; +} + +ol[type="a"] { + list-style-type: lower-alpha; +} + +ol[type="i"] { + list-style-type: lower-roman; +} + dd { margin-left: 0; } From 1074565085eea0b7f41fb50cfc0e1b1bf345cce2 Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Tue, 27 Apr 2021 08:57:04 -0700 Subject: [PATCH 2/4] Update lists.scss --- src/markdown/lists.scss | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/markdown/lists.scss b/src/markdown/lists.scss index 30efc9ec84..b7a18a5c26 100644 --- a/src/markdown/lists.scss +++ b/src/markdown/lists.scss @@ -13,6 +13,19 @@ list-style-type: none; } } + + ol[type="1"] { + list-style-type: decimal; + } + + ol[type="a"] { + list-style-type: lower-alpha; + } + + ol[type="i"] { + list-style-type: lower-roman; + } + // Did someone complain about list spacing? Encourage them // to create the spacing with their markdown formatting. From 7be59c359bc0ca6d6125bc1c6d68b630c2424774 Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Tue, 27 Apr 2021 08:57:36 -0700 Subject: [PATCH 3/4] Update typography-base.scss --- src/base/typography-base.scss | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/src/base/typography-base.scss b/src/base/typography-base.scss index 07fc94dccd..83eb995279 100644 --- a/src/base/typography-base.scss +++ b/src/base/typography-base.scss @@ -58,18 +58,6 @@ ol ol ol { list-style-type: lower-alpha; } -ol[type="1"] { - list-style-type: decimal; -} - -ol[type="a"] { - list-style-type: lower-alpha; -} - -ol[type="i"] { - list-style-type: lower-roman; -} - dd { margin-left: 0; } From 3dfb910fc39ae889fb4c2c3c783aead6ac768d0d Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Tue, 27 Apr 2021 08:58:34 -0700 Subject: [PATCH 4/4] Create odd-foxes-invite.md --- .changeset/odd-foxes-invite.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/odd-foxes-invite.md diff --git a/.changeset/odd-foxes-invite.md b/.changeset/odd-foxes-invite.md new file mode 100644 index 0000000000..c85ba04413 --- /dev/null +++ b/.changeset/odd-foxes-invite.md @@ -0,0 +1,5 @@ +--- +"@primer/css": minor +--- + +typography-base: process 'type' attribute of HTML
        tag