Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Width #32

Open
vanor89 opened this issue Jun 8, 2017 · 3 comments
Open

Width #32

vanor89 opened this issue Jun 8, 2017 · 3 comments

Comments

@vanor89
Copy link

vanor89 commented Jun 8, 2017

Can a width be added? I have a ultra widescreen monitor and I don't need the terminal to be that long.

@gattazr
Copy link

gattazr commented Jul 9, 2017

@carlosv89 Did you try to use the position 'left' or 'right' ?
If you use the positions left or right the param size will control the width of the window and not its height.

Or do you wish to control both the height and width of your hyper window ?

EDIT: I've opened #33 if you were thinking of the latter

@TheDan64
Copy link

I also think the width should be customizable. The size attribute applies only to height

@favna
Copy link

favna commented Jun 28, 2018

The size config property actually applies 1 value to both height and width at the same time

switch(this._config.position) {
case 'left':
size = (this._config.size > 1) ? this._config.size : Math.round(width * this._config.size);
this._win.setBounds({ x: x, y: y, width: size, height: height }, this._config.animate);
break;
case 'bottom':
size = (this._config.size > 1) ? this._config.size : Math.round(height * this._config.size);
this._win.setBounds({ x: x, y: y + height - size, width: width, height: size }, this._config.animate);
break;

I have changed the size settings to an object in my fork hyper-overlay so now it is like:

      size: {
        width: 0.4,
        height: 0.4
      },

Conclusion: Fixed as per v1.1.0 of my fork. Specific commit is here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants