Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to save media or files via Desktop on Linux, while Android works fine #6912

Open
2 tasks done
arcivanov opened this issue Jun 14, 2024 · 41 comments · May be fixed by #7108
Open
2 tasks done

Unable to save media or files via Desktop on Linux, while Android works fine #6912

arcivanov opened this issue Jun 14, 2024 · 41 comments · May be fixed by #7108

Comments

@arcivanov
Copy link

arcivanov commented Jun 14, 2024

Using a supported version?

  • I have searched searched open and closed issues for duplicates.
  • I am using Signal-Desktop as provided by the Signal team, not a 3rd-party package.

Overall summary

Files don't save on Signal on Linux 7.12, 7.11

Steps to reproduce

  1. Receive a file (playable video OR text MIME)
  2. Click on Save
  3. Dialog pops up to save file, click save
  4. Dialog closes, nothing happens.

No file is create locally of any length.

NB!!! The Debug Log doesn't save locally either. So it looks like a global UI problem.

Expected result

File saves, like before

Actual result

No file is saved.

Screenshots

No response

Signal version

7.12.0

Operating system

Fedora 40

Version of Signal on your phone

Android 7.8.1

Link to debug log

https://debuglogs.org/desktop/7.12.0/154122acdbd7e63197c790160a5db61424b156bf6e7457f6bad8255fc3438c1b.gz

@HITMAnsOFT
Copy link

Same issue on Kubuntu 22.04.4 LTS, Signal 7.12.0, both Snap and official deb packages.

@akutuzov
Copy link

Same here, also Kubuntu 22.04.4 and Signal 7.12.0

@ghost
Copy link

ghost commented Jun 15, 2024

Same issue on Arch with version 7.12.0. The only way I've found to save images is to open it and drag the actual image to my file manager (which doesn't give any indication of dragging anything, but still works). This doesn't work with videos or other file types, though, because they can't be dragged.

Also when clicking the download button, this gets written to the journal, as well as to stderr if Signal is started from a terminal:

[122855:0615/153714.144870:ERROR:select_file_dialog_linux_portal.cc(760)] Portal returned error: org.freedesktop.DBus.Error.AccessDenied: Portal operation not allowed: Unable to open /proc/122855/root

@rafasaurus
Copy link

Same issue on Arch linux wtih version 7.12.0.

@trevor-signal
Copy link
Contributor

Thanks for the reports. 7.11 introduced a new Electron version (v30), which is possibly related. I've created an Electron Fiddle gist here: https://gist.github.com/trevor-signal/95c543c5e7cd398c6957c78b5cc9fe94. I'd love to know if the save dialog opens on:

  • Electron 30.0.9 (current)
  • Electron 29.1.5 (used by Signal 7.10)
  • Electron 31.0.1

Thanks for your help!

@arcivanov
Copy link
Author

There is no problem with the opening of the save dialog. It's just after the save dialog is closed with "Save", nothing happens.

@trevor-signal
Copy link
Contributor

Others, can you share debug logs? We're having difficulty reproducing.

@mrvanes
Copy link

mrvanes commented Jun 18, 2024

Another debug log: https://debuglogs.org/desktop/7.12.0/3c05aa67fa8f85922db87ba1cf7e02a474325806f232b17c8c3595c2da1cc9fd.gz

Maybe mentioning that I'm running Signal Desktop in a Wayland session helps?

@arcivanov
Copy link
Author

Yes, I'm also on Wayland.

@rafasaurus
Copy link

rafasaurus commented Jun 19, 2024

  • 29.1.5

I have tested as you say, only in 29.1.5 opens file dialog, with 30 and 31 file dialog does not even open, I'm using xorg on Arch.

@HITMAnsOFT
Copy link

I am running on Xorg. Fiddle opens dialog fine on all versions, but as @arcivanov said both in the description and in the comment, nothing is actually saved.

@palant
Copy link

palant commented Jun 24, 2024

For what it’s worth, this is unrelated to flatpak. If I run the signal-desktop binary directly, it runs outside of the flatpak sandbox but is still unable to save files – dialog opens but clicking “Save” doesn’t actually save the file. Signal 7.13.0 on Fedora 40 (KDE, Wayland).

Thanks for the reports. 7.11 introduced a new Electron version (v30), which is possibly related. I've created an Electron Fiddle gist here: https://gist.github.com/trevor-signal/95c543c5e7cd398c6957c78b5cc9fe94. I'd love to know if the save dialog opens on:

* Electron 30.0.9 (current)

* Electron 29.1.5 (used by Signal 7.10)

* Electron 31.0.1

Thanks for your help!

@trevor-signal I’ve slightly modified your fiddle to actually display the file path returned by showSaveDialog(). The affected Electron versions always return an empty path, that’s the issue here. Versions I tested:

  • Electron 29.1.5: not affected
  • Electron 30.0.2: not affected
  • Electron 30.0.3: not affected
  • Electron 30.0.4: affected
  • Electron 30.0.5: affected
  • Electron 30.0.9: affected
  • Electron 30.1.2: affected
  • Electron 31.0.1: affected
  • Electron 31.0.2: affected

In affected versions, the dialog looks considerably different. Given that and the regression range, it’s a safe bet that this regression was caused by electron#42110.

@palant
Copy link

palant commented Jun 24, 2024

While experimenting with this, I found a work-around. Initially, the Save File dialog incorrectly displays “/” above the file list. Click “Home” first, which will make it display “Home” there (listed files don’t change but some icons do). Then you can select directory/file name and saving will work. There seems to be some issue with the directory paths.

@would1920
Copy link

\

While experimenting with this, I found a work-around. Initially, the Save File dialog incorrectly displays “/” above the file list. Click “Home” first, which will make it display “Home” there (listed files don’t change but some icons do). Then you can select directory/file name and saving will work. There seems to be some issue with the directory paths.在对此进行试验时,我找到了一种解决方法。最初,“保存文件”对话框在文件列表上方错误地显示“/”。首先单击“Home”,这将使其显示“Home”(列出的文件不会更改,但某些图标会更改)。然后您可以选择目录/文件名并保存即可。目录路径似乎存在一些问题。

It worked for me!!!

@cheazycrust
Copy link

While experimenting with this, I found a work-around. Initially, the Save File dialog incorrectly displays “/” above the file list. Click “Home” first, which will make it display “Home” there (listed files don’t change but some icons do). Then you can select directory/file name and saving will work. There seems to be some issue with the directory paths.

can confirm this worked for me too!!

@arcivanov
Copy link
Author

While experimenting with this, I found a work-around. Initially, the Save File dialog incorrectly displays “/” above the file list. Click “Home” first, which will make it display “Home” there (listed files don’t change but some icons do). Then you can select directory/file name and saving will work. There seems to be some issue with the directory paths.

Confirm this works for me too! Great job!

@mrvanes
Copy link

mrvanes commented Jun 24, 2024

Yes, it works. Thx!
Tiny correction to the observation: the dialog initially points to ./ (for me). Not /.

@cegfault
Copy link

cegfault commented Jul 3, 2024

Indeed the dialog initially points to ./

I tried changing the dialog prompt to ~/ (home directory), which solves this problem on linux. / also solves the problem, but ~/ may be preferred for obvious reasons.

@zparihar
Copy link

While experimenting with this, I found a work-around. Initially, the Save File dialog incorrectly displays “/” above the file list. Click “Home” first, which will make it display “Home” there (listed files don’t change but some icons do). Then you can select directory/file name and saving will work. There seems to be some issue with the directory paths.

Great Catch! It worked for me. Doesn't sound like its electron. Sounds like its just the programming of the default path.

@trevor-signal
Copy link
Contributor

This should be resolved by Electron 31.2.0, via electron/electron#42685, which is currently in v7.17.0-beta.1

@RES-1
Copy link

RES-1 commented Jul 22, 2024

This does not seem to have solved the problem:

electron/electron#42250 (comment)

@toxpal
Copy link

toxpal commented Jul 28, 2024

Same problem here, at least now I know I have to manually remove / from path...

@ayumi-signal ayumi-signal reopened this Jul 29, 2024
@Wardevour
Copy link

7.17.0 still has the problem. Reinstalling doesn't seem to help.

While experimenting with this, I found a work-around. Initially, the Save File dialog incorrectly displays “/” above the file list. Click “Home” first, which will make it display “Home” there (listed files don’t change but some icons do). Then you can select directory/file name and saving will work. There seems to be some issue with the directory paths.

The workaround above still works

@kamazeuci
Copy link

7.20.0 production still has the problem

@koutheir
Copy link

koutheir commented Aug 21, 2024

Version 7.20.1 production still has the problem on Debian 12, using package signal-desktop installed using apt. Running on X11.

@arcivanov
Copy link
Author

On Signal 7.24.1 for Linux. The / directory has been replaced by "$HOME", which seems like the sign of progress. However the name of the file is now lost and has to be entered manually to save.

@palant
Copy link

palant commented Sep 17, 2024

Signal 7.24.1 for Linux here as well, I see no changes whatsoever. I still see exactly the same thing as in #6912 (comment).

@godspeedyou
Copy link

7.28.0 now shows sth like: http://signal-2024-10-13-190627_005.jpeg as the file name.

It's funny how there seem to be changes every few versions to this function, but this issue just doesn't get fixed.

@arcivanov
Copy link
Author

7.28.0 now shows sth like: http://signal-2024-10-13-190627_005.jpeg as the file name.

It's funny how there seem to be changes every few versions to this function, but this issue just doesn't get fixed.

I confirm on Fedora 41.

@major-mayer
Copy link
Contributor

7.28.0 now shows sth like: http://signal-2024-10-13-190627_005.jpeg as the file name.

It's funny how there seem to be changes every few versions to this function, but this issue just doesn't get fixed.

I've found something even stranger. Try this:

  • Open a chat where somebody send you two file attachments directly after each other
  • Try to open/ download the first one (the one that you received earlier)
  • Notice how the suggested filename is now your home directory ($HOME variable)
  • Try to open/ download the second one (the one that you received later)
  • Notice how it starts with "http://" followed by either the filename or a generated name

Some screenshot from KDE Plasma for better illustration:
Bildschirmfoto_20241016_194149
Bildschirmfoto_20241016_194049

@password123123123
Copy link

image

Got this in notification and next got save file dialog with blank name after pressing stop.

@markum
Copy link

markum commented Nov 8, 2024

Hawing this problem as well. Changing the configuration in the config does nothing. Have still this http:// in front of the file name instead of the path

@lilacdev
Copy link

Having this issue for a while now. Using signal with Debien 12 and KDE Plasma. Glad to see I am not alone. It is quite frustrating to type the whole filename everytime.

@password123123123
Copy link

For me it looks like some bug in kdialog or at least in signal->kdialog interoperability.
When I start image download signal shows the kdialog "Checking" notification with this "http://signal-xxxx-xx-xxxx.jpeg" nonsense. And the process command is folow: "
kdialog --attach=20971524 --title=Save file --getsavefilename signal-2024-11-06-163605_005.jpeg
" (ps -aux | grep kdialog).
When I tried to execute this (quoting --title value) it's show save dialog with empty filename and "http://filename" shit.
зображення

If I replace --getsavefilename with fullpath filename i.e. "/home/putin_hujlo/123.jpg" the save dialog displayed correctly and filename field is not empty.

@akutuzov
Copy link

@trevor-signal is there any chance this issue will get fixed in the foreseeable future?
It seems that if affects everyone on Linux+KDE (at least). And it's really very frustrating.

@palant
Copy link

palant commented Nov 21, 2024

At least for me it is fixed in 7.30.0 on Fedora 40 now (Edit: same in 7.34.0). I see an entirely different dialog that doesn’t exhibit this issue (and doesn’t respect my color scheme either). I can still reproduce the issue by running kdialog as per #6912 (comment) but not in Signal any more.

@akutuzov
Copy link

Kubuntu 24.04.1 LTS, Signal Desktop 7.34.0. Downloading any file from the Signal app still results in "http://FILENAME" instead of any real path. The filename field is empty. To actually save a file, I have to always manually replace "http://FILENAME" with the actual path and to type the filename.

image

@lilacdev
Copy link

I can add a test case :

  • If multiple files are present, then saving all files works as expected
  • This issue occurs only when there is a single file

pelya added a commit to pelya/Signal-Desktop that referenced this issue Dec 5, 2024
This fixes signalapp#6912.
On Gnome the save dialog works with any filename, on KDE Plasma
the save dialog opens with an empty filename input field,
unless the application uses an absolute file path instead of only the filename.
This commit will use the ~/Downloads directory as the default path,
which seems like a better choice then dumping files into the user's home dir.
pelya added a commit to pelya/Signal-Desktop that referenced this issue Dec 5, 2024
This fixes signalapp#6912.
On Gnome the save dialog works with any filename, on KDE Plasma
the save dialog opens with an empty filename input field,
unless the application uses an absolute file path instead of only the filename.
This commit will use the ~/Downloads directory as the default path,
which seems like a better choice then dumping files into the user's home dir.
pelya added a commit to pelya/Signal-Desktop that referenced this issue Dec 5, 2024
This fixes signalapp#6912.
On Gnome the save dialog works with any filename, on KDE Plasma
the save dialog opens with an empty filename input field,
unless the application uses an absolute file path instead of only the filename.
This commit will use the ~/Downloads directory as the default path,
which seems like a better choice then dumping files into the user's home dir.
@pelya pelya linked a pull request Dec 5, 2024 that will close this issue
7 tasks
@pelya
Copy link
Contributor

pelya commented Dec 13, 2024

Hey, please merge my patch before releasing a new version. The official Signal release just installed over my custom build on my PC and re-introduced the bug, and I cannot reinstall my custom build because the official release already updated the database version, and it's too much work to make another custom build based on 7.36.0 and disable updates for signal-desktop Debian package, after I've already created and tested the fix. I'm going to keep complaining here in this issue thread each time anyone sends me another .pdf file using Signal. Thank you for your attention.

pelya added a commit to pelya/Signal-Desktop that referenced this issue Dec 13, 2024
This fixes signalapp#6912.
On Gnome the save dialog works with any filename, on KDE Plasma
the save dialog opens with an empty filename input field,
unless the application uses an absolute file path instead of only the filename.
The default save location is the Downloads directory in the user's home directory.
@Crell
Copy link

Crell commented Jan 5, 2025

This issue is still present for me, running Signal 7.36.1 on Kubuntu 22.04. In my case, the save dialog source pre-fills not with ./, but with http: signal-2025-01-03-1324165.jpeg (or similar). If I supply my own file name and hit save, I get an error The selected URL uses an unsupported scheme. Please use the following scheme: file.

The workaround from @palant (#6912 (comment)) does seem to still work, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.