-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to save media or files via Desktop on Linux, while Android works fine #6912
Comments
Same issue on Kubuntu 22.04.4 LTS, Signal 7.12.0, both Snap and official deb packages. |
Same here, also Kubuntu 22.04.4 and Signal 7.12.0 |
Same issue on Arch with version 7.12.0. The only way I've found to save images is to open it and drag the actual image to my file manager (which doesn't give any indication of dragging anything, but still works). This doesn't work with videos or other file types, though, because they can't be dragged. Also when clicking the download button, this gets written to the journal, as well as to stderr if Signal is started from a terminal:
|
Same issue on Arch linux wtih version 7.12.0. |
Thanks for the reports. 7.11 introduced a new Electron version (v30), which is possibly related. I've created an Electron Fiddle gist here: https://gist.github.com/trevor-signal/95c543c5e7cd398c6957c78b5cc9fe94. I'd love to know if the save dialog opens on:
Thanks for your help! |
There is no problem with the opening of the save dialog. It's just after the save dialog is closed with "Save", nothing happens. |
Others, can you share debug logs? We're having difficulty reproducing. |
Another debug log: https://debuglogs.org/desktop/7.12.0/3c05aa67fa8f85922db87ba1cf7e02a474325806f232b17c8c3595c2da1cc9fd.gz Maybe mentioning that I'm running Signal Desktop in a Wayland session helps? |
Yes, I'm also on Wayland. |
I have tested as you say, only in 29.1.5 opens file dialog, with 30 and 31 file dialog does not even open, I'm using xorg on Arch. |
I am running on Xorg. Fiddle opens dialog fine on all versions, but as @arcivanov said both in the description and in the comment, nothing is actually saved. |
For what it’s worth, this is unrelated to flatpak. If I run the
@trevor-signal I’ve slightly modified your fiddle to actually display the file path returned by
In affected versions, the dialog looks considerably different. Given that and the regression range, it’s a safe bet that this regression was caused by electron#42110. |
While experimenting with this, I found a work-around. Initially, the Save File dialog incorrectly displays “/” above the file list. Click “Home” first, which will make it display “Home” there (listed files don’t change but some icons do). Then you can select directory/file name and saving will work. There seems to be some issue with the directory paths. |
\
It worked for me!!! |
can confirm this worked for me too!! |
Confirm this works for me too! Great job! |
Yes, it works. Thx! |
Indeed the dialog initially points to I tried changing the dialog prompt to |
Great Catch! It worked for me. Doesn't sound like its electron. Sounds like its just the programming of the default path. |
This should be resolved by Electron 31.2.0, via electron/electron#42685, which is currently in v7.17.0-beta.1 |
This does not seem to have solved the problem: |
Same problem here, at least now I know I have to manually remove / from path... |
7.17.0 still has the problem. Reinstalling doesn't seem to help.
The workaround above still works |
7.20.0 production still has the problem |
Version |
On Signal 7.24.1 for Linux. The |
Signal 7.24.1 for Linux here as well, I see no changes whatsoever. I still see exactly the same thing as in #6912 (comment). |
7.28.0 now shows sth like: http://signal-2024-10-13-190627_005.jpeg as the file name. It's funny how there seem to be changes every few versions to this function, but this issue just doesn't get fixed. |
I confirm on Fedora 41. |
I've found something even stranger. Try this:
|
Hawing this problem as well. Changing the configuration in the config does nothing. Have still this http:// in front of the file name instead of the path |
Having this issue for a while now. Using signal with Debien 12 and KDE Plasma. Glad to see I am not alone. It is quite frustrating to type the whole filename everytime. |
For me it looks like some bug in kdialog or at least in signal->kdialog interoperability. If I replace --getsavefilename with fullpath filename i.e. "/home/putin_hujlo/123.jpg" the save dialog displayed correctly and filename field is not empty. |
@trevor-signal is there any chance this issue will get fixed in the foreseeable future? |
At least for me it is fixed in 7.30.0 on Fedora 40 now (Edit: same in 7.34.0). I see an entirely different dialog that doesn’t exhibit this issue (and doesn’t respect my color scheme either). I can still reproduce the issue by running |
Kubuntu 24.04.1 LTS, Signal Desktop 7.34.0. Downloading any file from the Signal app still results in "http://FILENAME" instead of any real path. The filename field is empty. To actually save a file, I have to always manually replace "http://FILENAME" with the actual path and to type the filename. |
I can add a test case :
|
This fixes signalapp#6912. On Gnome the save dialog works with any filename, on KDE Plasma the save dialog opens with an empty filename input field, unless the application uses an absolute file path instead of only the filename. This commit will use the ~/Downloads directory as the default path, which seems like a better choice then dumping files into the user's home dir.
This fixes signalapp#6912. On Gnome the save dialog works with any filename, on KDE Plasma the save dialog opens with an empty filename input field, unless the application uses an absolute file path instead of only the filename. This commit will use the ~/Downloads directory as the default path, which seems like a better choice then dumping files into the user's home dir.
This fixes signalapp#6912. On Gnome the save dialog works with any filename, on KDE Plasma the save dialog opens with an empty filename input field, unless the application uses an absolute file path instead of only the filename. This commit will use the ~/Downloads directory as the default path, which seems like a better choice then dumping files into the user's home dir.
Hey, please merge my patch before releasing a new version. The official Signal release just installed over my custom build on my PC and re-introduced the bug, and I cannot reinstall my custom build because the official release already updated the database version, and it's too much work to make another custom build based on 7.36.0 and disable updates for signal-desktop Debian package, after I've already created and tested the fix. I'm going to keep complaining here in this issue thread each time anyone sends me another .pdf file using Signal. Thank you for your attention. |
This fixes signalapp#6912. On Gnome the save dialog works with any filename, on KDE Plasma the save dialog opens with an empty filename input field, unless the application uses an absolute file path instead of only the filename. The default save location is the Downloads directory in the user's home directory.
This issue is still present for me, running Signal 7.36.1 on Kubuntu 22.04. In my case, the save dialog source pre-fills not with The workaround from @palant (#6912 (comment)) does seem to still work, though. |
Using a supported version?
Overall summary
Files don't save on Signal on Linux 7.12, 7.11
Steps to reproduce
No file is create locally of any length.
NB!!! The Debug Log doesn't save locally either. So it looks like a global UI problem.
Expected result
File saves, like before
Actual result
No file is saved.
Screenshots
No response
Signal version
7.12.0
Operating system
Fedora 40
Version of Signal on your phone
Android 7.8.1
Link to debug log
https://debuglogs.org/desktop/7.12.0/154122acdbd7e63197c790160a5db61424b156bf6e7457f6bad8255fc3438c1b.gz
The text was updated successfully, but these errors were encountered: