-
-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Typescript) Expose classList type #2378
Comments
We are in the process of meditating if It has issues like defining both I am probably missing some other situation. I meant to investigate this. While I somewhat understand the issue, I am not confident enough about its problems (it only happens in some circumstances and most of the time is not an issue or a big deal), and I am also not authoritative enough to decide over its future. btw, the typings are in https://github.com/ryansolid/dom-expressions/blob/main/packages/dom-expressions/src/jsx.d.ts I mentioned all of the above because we do not seem to be sure about its future, so you can consider |
I think deprecating or removing classList is irrelevant. It will stay in 1.x anyway (removing it would be a breaking change), so exposing its type makes sense I think. |
I'm just not sure what package should export the type. I'm thinking solid/web? If so, then: #2401 |
Currently exposing classList as a prop requires a custom type. It would be better to create a "ClassList" type definition, use that everywhere and expose it. PR following shortly.
The text was updated successfully, but these errors were encountered: