feat: add column_index_operation
#396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlovell-sxt
reviewed
Dec 3, 2024
crates/proof-of-sql/src/base/database/column_index_operation.rs
Outdated
Show resolved
Hide resolved
crates/proof-of-sql/src/base/database/column_index_operation.rs
Outdated
Show resolved
Hide resolved
crates/proof-of-sql/src/base/database/column_index_operation.rs
Outdated
Show resolved
Hide resolved
crates/proof-of-sql/src/base/database/column_index_operation.rs
Outdated
Show resolved
Hide resolved
iajoiner
force-pushed
the
feat/apply-index
branch
5 times, most recently
from
ccca278 to
d763e97
Compare
iajoiner
force-pushed
the
feat/apply-index
branch
from
d763e97 to
8ec25f7
Compare
iajoiner
force-pushed
the
feat/apply-index
branch
from
8ec25f7 to
be57a48
Compare
iajoiner
force-pushed
the
feat/apply-index
branch
from
be57a48 to
3295dfb
Compare
tlovell-sxt
approved these changes
Dec 4, 2024
| column: &Column<'a, S>, | ||
| alloc: &'a Bump, | ||
| indexes: &[usize], | ||
| ) -> ColumnOperationResult<Column<'a, S>> |
There was a problem hiding this comment.
NIT: This comment might not be useful depending on how this function will be used later. Without that context, I'd say it would be better if the error type was just a new IndexOutOfBounds error type since most of the column operation errors cannot occur in this function. But if this function is only ever used in contexts that are dealing with that error type, then it's probably fine.
|
🎉 This PR is included in version 0.57.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
iajoiner
added a commit
that referenced
this pull request
Dec 18, 2024
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr. # Please go through the following checklist - [x] The PR title and commit messages adhere to guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md. In particular `!` is used if and only if at least one breaking change has been introduced. - [x] I have run the ci check script with `source scripts/run_ci_checks.sh`. - The following upstream PRs have been approved and merged: - [x] #391 - [x] #396 # Rationale for this change This PR adds the actual sort-merge join process which completes a part of #394. <!-- Why are you proposing this change? If this is already explained clearly in the linked issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. Example: Add `NestedLoopJoinExec`. Closes #345. Since we added `HashJoinExec` in #323 it has been possible to do provable inner joins. However performance is not satisfactory in some cases. Hence we need to fix the problem by implement `NestedLoopJoinExec` and speed up the code for `HashJoinExec`. --> # What changes are included in this PR? - add `sort_merge_join`. <!-- There is no need to duplicate the description in the ticket here but it is sometimes worth providing a summary of the individual changes in this PR. Example: - Add `NestedLoopJoinExec`. - Speed up `HashJoinExec`. - Route joins to `NestedLoopJoinExec` if the outer input is sufficiently small. --> # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? Example: Yes. --> Yes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.Rationale for this change
In sort-merge joins we need to be able to apply columns to possibly repetitive indexes. Hence let's add this before actually adding
sort_merge_join.What changes are included in this PR?
ColumnOperationError::IndexOutOfBounds.apply_slice_to_indexesinslice_operation.rs.IndexOpandApplyIndexOpto apply the new op toColumns.Are these changes tested?
Yes.