Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support accepting interceptors in WebSocketGraphQlTester #823

Closed
MarekSvatos opened this issue Sep 21, 2023 · 3 comments
Closed

Support accepting interceptors in WebSocketGraphQlTester #823

MarekSvatos opened this issue Sep 21, 2023 · 3 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@MarekSvatos
Copy link

I am struggling to find a way to set connection_init payload using WebSocketGraphQlTester. It would be nice for WebSocketGraphQlTester to support accepting interceptors in the same way that WebSocketGraphQlClient does.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 21, 2023
@MarekSvatos MarekSvatos changed the title Support setting connection_init payload for WebSocketGraphQlTester Support accepting interceptors in WebSocketGraphQlTester Sep 21, 2023
@rstoyanchev rstoyanchev added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Oct 13, 2023
@rstoyanchev rstoyanchev added this to the 1.3 Backlog milestone Oct 13, 2023
@rstoyanchev
Copy link
Contributor

It makes sense to expose interceptors on GraphQlTester.Builder which would in turn configure them on the underlying GraphQlClient.

@rstoyanchev rstoyanchev modified the milestones: 1.3 Backlog, 1.3.0-RC1 Apr 11, 2024
@bclozel bclozel self-assigned this Apr 12, 2024
@bclozel
Copy link
Member

bclozel commented Apr 15, 2024

I had a look and it seems that configuring interceptors on the client is only possible for the WebSocketGraphQlTester, as other variants are dealing with the transport directly. We should probably apply this at the GraphQlTester.Builder level: this means we need to apply this consistently to all tester implementations.

@bclozel bclozel modified the milestones: 1.3.0-RC1, 1.3.0 Apr 15, 2024
@bclozel
Copy link
Member

bclozel commented Apr 19, 2024

After discussing this again, we thought that the main use case for interceptors with testers is the one described above. We've added this possibility on the WebSocketGraphQlTester builder only, for now. If we get other requests from the community with concrete use cases, we can reconsider and promote this to a higher level builder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants