Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Terminal input cannot handle emojis properly, causing duplicated letters and wrong display #1633

Open
3 tasks
Real-YueWu opened this issue Dec 27, 2024 · 0 comments
Labels
bug Something isn't working triage Needs triage

Comments

@Real-YueWu
Copy link

Current Behavior

I'm using Wave terminal with zsh and oh-my-zsh powerlevel10k theme. When I try to input something, some letters will always duplicate, here is the video.

20241227_143206.mp4

However, iTerm2 and the default Terminal app do not have this issue. Therefore, I try to find the reason. I found that the p10k's right border are not aligned properly, like this figure:

Upper represent alignment in Wave, lower represent alignment in iTerm2

The only difference of the first line and the last two lines is the emoji, so I try to add more emoji on the second line to replicate this issue. With more emoji added on the third line, the right indicator line of the third line is more to the left. Also, the two emoji stars overlap.
image

In order to exclude the inference of zsh and oh-my-zsh, I try to reproduce this in bash. When I input emoji, the emojis are still overlapped with each other, and deleting will cause wrong display:

20241227_144741.mp4

So, I think the wrong emoji display caused this issue. I'm a newcomer of programming, so I'm not good at typescript or css or something, and my inference may be wrong😆.

Finally, I love this project! Thank you for your contributions!

Expected Behavior

All lines should display properly, and emojis should not overlap with each other.

Steps To Reproduce

  1. Open Wave terminal
  2. Input some emojis
  3. Delete emojis

Wave Version

v0.10.4

Platform

macOS

OS Version/Distribution

macOS 14.7.1

Architecture

arm64

Anything else?

No response

Questionnaire

  • I'm interested in fixing this myself but don't know where to start
  • I would like to fix and I have a solution
  • I don't have time to fix this right now, but maybe later
@Real-YueWu Real-YueWu added bug Something isn't working triage Needs triage labels Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage Needs triage
Projects
None yet
Development

No branches or pull requests

1 participant