-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display connection rejection errors passed to client #6101
Display connection rejection errors passed to client #6101
Conversation
c66baf3
to
c26e9fd
Compare
c26e9fd
to
505f9ed
Compare
ec900cb
to
c03344e
Compare
To trigger this on demand, your can add this listen_socket.py in import random
if random.random() < 0.2:
raise ConnectionRefusedError('Dev injected random failure') |
Co-authored-by: sp.wack <[email protected]>
I think e2e ran successfully before, it might just need to rerun |
Yes it happens sometimes |
Does it just retry on its own or is there something we press to restart it? |
Click on the failed job -> scroll up and you'll see something like "Re-run jobs" on the top right. Click it and the "Re-run failed jobs only" option. I've already done it by the time you've commented 😃 |
End-user friendly description of the problem this fixes or functionality that this introduces
Give a summary of what the PR does, explaining any non-trivial design decisions
In our backend, we raise ConnectionRefusedError. SocketIO passes that message to the client. The client did ignore it but will now display it to the user.
Open questions
We may need to find a way to prevent the same message from displaying repeatedly, if so we can handle this more generally later, e.g. by showing repeated messages with a count.
This does not give the message an id, which appears to be for i18n. However some of the other uses seem to omit id as well so the type has been updated to more accurately reflect this as an optional field.
Link of any specific issues this addresses
ALL-959