Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resolver] (refactor) Generalize the resolver #6125

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

cuococarlos
Copy link

End-user friendly description of the problem this fixes or functionality that this introduces

This PR separates the logic of GitHub from the resolver component. The final objective is for OpenHands to use in various code repositories, not just GitHub.
This PR has two steps to achieve the objective:

  • A new handler to manage all pull requests and issue logic

  • Make the resolver's GitHub-related logic more abstract and give GitHub's logic to the GithubIssueHandler class.

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below


Give a summary of what the PR does, explaining any non-trivial design decisions

Here are some important decisions:

  • Move all the Github logic to the new file. Openhands/resolver/github.py will create GithubIssueHandler and GithubPRHandler.
  • Make the classes that were Github-specific general so that they can fulfill an interface. This will allow new classes to be generated that can be adapted to other solutions.
  • Adapt the tests for the above changes.

Link of any specific issues this addresses
[Resolver]: Gitlab support #5210

@cuococarlos cuococarlos changed the title [Resolver] (refactor) Generalize the resolver to [Resolver] (refactor) Generalize the resolver Jan 7, 2025
@neubig neubig requested review from neubig and malhotra5 January 8, 2025 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants