-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Resolver] (refactor) Generalize the resolver #6125
Draft
cuococarlos
wants to merge
18
commits into
All-Hands-AI:main
Choose a base branch
from
Cambalab:resolver_abs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,188
−908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: José Luis Di Biase <[email protected]>
…nction refactor(resolver) add pull url and authorize url functions
branch_exists and get_branch_name functions refactored
* get_branch_url * implemente get_branch_url() in branch_exists() * get_branch_url --------- Co-authored-by: Charlie <[email protected]>
cuococarlos
changed the title
[Resolver] (refactor) Generalize the resolver to
[Resolver] (refactor) Generalize the resolver
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
This PR separates the logic of GitHub from the resolver component. The final objective is for OpenHands to use in various code repositories, not just GitHub.
This PR has two steps to achieve the objective:
A new handler to manage all pull requests and issue logic
Make the resolver's GitHub-related logic more abstract and give GitHub's logic to the GithubIssueHandler class.
Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below
Give a summary of what the PR does, explaining any non-trivial design decisions
Here are some important decisions:
Link of any specific issues this addresses
[Resolver]: Gitlab support #5210