fixed global styles #1241
fixed global styles #1241
Conversation
|
Please make sure to be pasted screenshots of all your changes. |
|
This is how it looks like now: |
.gitignore
Outdated
| @@ -8,3 +8,5 @@ node_modules/* | |||
| /compiled | |||
| /secret | |||
| *.log | |||
| .vscode | |||
| .idea | |||
There was a problem hiding this comment.
I think that .vscode and .idea are unnecessary. Could you remove them?
There was a problem hiding this comment.
I just added them, because I use both editors and always have to be careful not to commit those IDE specific files. Is it a real problem that we add them here?
There was a problem hiding this comment.
I understand your opinion, but I think that we should merge only generally code (not only for us) because Boostnote is open source.
There was a problem hiding this comment.
We don't think it is unnecessary to add .idea and .vscode into .gitignore. However, if many contributors want it, we'll add it. 😄
And, This pull request is "fixed global styles". could you create new pull request for add it.?🙏
|
I removed the gitignore changes and created a new PR with these changes: #1242 |
|
Thanks @mslourens ! I will check this tomorrow. |
|
Merged. Thanks @mslourens ! |
kazup01
added
next release (v0.8.19)
and removed
awaiting review ❇️
fixes #1240