I fixed the behavior of the editor when the enter key is pushed. #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 4, 2018 10:03
On enter key pushed, if already the line contains a token in markdown list, no completion is needed, I think. By this change, node_modules/codemirror/addon/edit/continueList.js could be trashed, but I can't because of the gitignore.
|
GJ!!:+1: I'll review this by tomorrow. How about to make another pull request against Codemirror to fix this problem? |
|
Thank you! |
Rokt33r
approved these changes
Feb 10, 2018
Rokt33r
added
next release (v0.9.0)
and removed
awaiting review ❇️
This was referenced Feb 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the enter key pushed, if already the line contains a token in markdown list, no completion is needed, I think.
For example, if I push the enter key when md is like below, and my cursor selects the head of the line,
the behavior before
the behavior after.
By this change, node_modules/codemirror/addon/edit/continueList.js could be trashed, but I can't because of the gitignore.