Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization #1640

Merged
merged 16 commits into from
Mar 17, 2018
Merged

Localization #1640

merged 16 commits into from
Mar 17, 2018

Conversation

Simon-the-Sorcerer
Copy link
Contributor

This is an approach to a multi language Interface as suggested in #1252. I started to implement a german translation. Other languages can be added easily.

@Rokt33r Rokt33r added the awaiting review ❇️ Pull request is awaiting a review. label Mar 7, 2018
@Rokt33r Rokt33r added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Mar 7, 2018
@Rokt33r
Copy link
Member

Rokt33r commented Mar 7, 2018

@sischae Did you finished?

@Simon-the-Sorcerer
Copy link
Contributor Author

Simon-the-Sorcerer commented Mar 7, 2018

yes, I'm done. The feature is ready to use. The only thing, that is incomplete, is the translation.

@Rokt33r Rokt33r added awaiting review ❇️ Pull request is awaiting a review. next release (v0.11.0) and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Mar 7, 2018
@Rokt33r Rokt33r self-requested a review March 7, 2018 17:02
@romainlq
Copy link
Contributor

romainlq commented Mar 8, 2018

Hey I'll be working on the french translation asap 👍
Edit : btw maybe we should setup en as the default language and not fr as mentioned in browser/main/Main.js ?

Edit 2: in the translation file, some words are in lowercase and some in uppercase, maybe we should all set to lowercase and then uppercase if needed in the components part ?

PS : Awesome work you did there @sischae !

@Simon-the-Sorcerer
Copy link
Contributor Author

I'll set the standard language to en and push it to my repo. I extracted the strings as they occur. Some occur in lowercase and some in uppercase in the source code.

What additional languages would you like to see? I would add them, so they only need to be translated.

@romainlq
Copy link
Contributor

romainlq commented Mar 9, 2018

As mentioned in #1252 , @ranaegis wanted support for Norwegian. Maybe @Rokt33r would love to add Korean support as well ?

Even better, we could create templates for all the languages supported on Boostnote website
So :

  • English
  • German (not on the website, but feel free to to the german translation 😄 )
  • Chinese (zh-CN)
  • Chinese (zh-TW)
  • Japanese
  • Portugese
  • Albanian
  • French
  • Korean
  • Polish
  • Spanish
  • Danish

@Rokt33r
Copy link
Member

Rokt33r commented Mar 9, 2018

Maybe @Rokt33r would love to add Korean support as well ?

I'll do Japanese and Korean.

@Simon-the-Sorcerer
Copy link
Contributor Author

I added the languages. Let the translation begin 😉

Btw: feels nice to work with you! 😃

@romainlq
Copy link
Contributor

Ok I'm done with the french translation ! 😄

@Rokt33r
Copy link
Member

Rokt33r commented Mar 12, 2018

@sischae I assume we need to use English by default. But, I found it uses Albanian at the first time.

Could you fix this?

screen shot 2018-03-12 at 11 23 07 am

@Simon-the-Sorcerer
Copy link
Contributor Author

Should work now. I forgot to set the default language in the DEFAULT_CONFIG. Can you test the new commit?

@justgerd
Copy link

I am happy to help with translations, if there is additional help required for German.

@nlopin
Copy link

nlopin commented Mar 14, 2018

I can do Russian

@bendo
Copy link

bendo commented Mar 16, 2018

Hi, I can do localization to Slovak language.

@Rokt33r Rokt33r merged commit 316e2ee into BoostIO:master Mar 17, 2018
@Simon-the-Sorcerer Simon-the-Sorcerer deleted the localization branch March 22, 2018 08:28
@Rokt33r Rokt33r added next release (v0.11.3) and removed awaiting review ❇️ Pull request is awaiting a review. labels Mar 22, 2018
@lfromanini
Copy link

I can translate it to Brazilian Portuguese. By the way, I took a look at the Json file and, if you allow me, my recommendation is to rename it to pt-br.json, so you can also have pt-pt for Portuguese from Portugal, which is a little bit different from Brazilian Portuguese. Just add me to the team if you want.

@Simon-the-Sorcerer
Copy link
Contributor Author

It's a good idea to rename the *.json files. You can fork the repo and add your changes to the code. Once you are done, open a pull request.

@lfromanini
Copy link

Done! ;)

#1747

@davidmigloz
Copy link
Contributor

I've just localized Boosnote to Spanish (#1748) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants