Add new future resize editor & Preview Panes by dragging.(#1977) #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosukesuzuki
requested changes
Jun 11, 2018
browser/components/CodeEditor.js
Outdated
| @@ -499,6 +499,7 @@ export default class CodeEditor extends React.Component { | |||
| fontFamily = _.isString(fontFamily) && fontFamily.length > 0 | |||
| ? [fontFamily].concat(defaultEditorFontFamily) | |||
| : defaultEditorFontFamily | |||
| let width = this.props.width | |||
There was a problem hiding this comment.
please use const instead of let.
| left -3px | ||
| z-index 10 | ||
| cursor col-resize | ||
|
|
There was a problem hiding this comment.
please remove unnecessary lines!
|
Fixed review suggestions. Please check |
| cursor col-resize | ||
|
|
||
|
|
||
| cursor col-resize |
There was a problem hiding this comment.
@zhouxiaoxiaoxujian
please add new line at end of the file!
sosukesuzuki
approved these changes
Jun 12, 2018
sosukesuzuki
added
next release (v0.11.6)
and removed
awaiting review ❇️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now dragging the border between Editor & Preview to left/right